Fix various pylint and pep8 errors

Check basic code-style problems for PEP-8
pep8 version: 2.4.0
./connectors/PYRO/__init__.py:57:43: E261 at least two spaces before inline comment
./connectors/SchemeEditor.py:29:21: E128 continuation line under-indented for visual indent
./controls/IDBrowser.py:101:23: E127 continuation line over-indented for visual indent
./controls/IDBrowser.py:102:23: E127 continuation line over-indented for visual indent

Check for problems using pylint ...
No config file found, using default configuration
pylint 1.9.4,
astroid 1.6.5
Python 2.7.16rc1 (default, Feb 18 2019, 11:05:09)
[GCC 8.2.0]
Use multiple threads for pylint
Using config file /home/developer/WorkData/PLC/beremiz/beremiz/.pylint
************* Module connectors.PYRO_dialog
connectors/PYRO_dialog.py:9: [W0611(unused-import), ] Unused import wx
************* Module connectors
connectors/__init__.py:32: [W1652(deprecated-types-field), ] Accessing a deprecated fields on the types module
connectors/__init__.py:32: [C0411(wrong-import-order), ] standard import "from types import ClassType" should be placed before "from connectors.ConnectorBase import ConnectorBase"
************* Module connectors.PYRO.PSK_Adapter
connectors/PYRO/PSK_Adapter.py:7: [C0411(wrong-import-order), ] standard import "import ssl" should be placed before "import sslpsk"
************* Module connectors.SchemeEditor
connectors/SchemeEditor.py:29: [C0330(bad-continuation), ] Wrong continued indentation (add 1 space).
wx.ALIGN_CENTER_VERTICAL),
^|
connectors/SchemeEditor.py:42: [W0631(undefined-loop-variable), SchemeEditor.__init__] Using possibly undefined loop variable 'tag'
************* Module runtime.WampClient
runtime/WampClient.py:138: [W1612(unicode-builtin), WampSession.onJoin] unicode built-in referenced
runtime/WampClient.py:154: [W1612(unicode-builtin), WampSession.publishWithOwnID] unicode built-in referenced
runtime/WampClient.py:346: [W1612(unicode-builtin), PublishEvent] unicode built-in referenced
runtime/WampClient.py:351: [W1612(unicode-builtin), PublishEventWithOwnID] unicode built-in referenced
runtime/WampClient.py:31: [W0611(unused-import), ] Unused str imported from builtins as text
************* Module runtime.PLCObject
runtime/PLCObject.py:35: [W1648(bad-python3-import), ] Module moved in Python 3
runtime/PLCObject.py:35: [C0411(wrong-import-order), ] standard import "import md5" should be placed before "from six.moves import xrange"
runtime/PLCObject.py:36: [C0411(wrong-import-order), ] standard import "from tempfile import mkstemp" should be placed before "from six.moves import xrange"
runtime/PLCObject.py:37: [C0411(wrong-import-order), ] standard import "import shutil" should be placed before "from six.moves import xrange"
runtime/PLCObject.py:38: [C0411(wrong-import-order), ] standard import "from functools import wraps, partial" should be placed before "from six.moves import xrange"
************* Module runtime.Worker
runtime/Worker.py:12: [W1648(bad-python3-import), ] Module moved in Python 3
************* Module runtime.spawn_subprocess
runtime/spawn_subprocess.py:125: [C0325(superfluous-parens), ] Unnecessary parens after 'print' keyword
runtime/spawn_subprocess.py:130: [C0325(superfluous-parens), ] Unnecessary parens after 'print' keyword
runtime/spawn_subprocess.py:125: [E1601(print-statement), ] print statement used
runtime/spawn_subprocess.py:130: [E1601(print-statement), ] print statement used
************* Module controls.IDBrowser
controls/IDBrowser.py:101: [C0330(bad-continuation), ] Wrong continued indentation (remove 5 spaces).
if self.isManager
| ^
controls/IDBrowser.py:102: [C0330(bad-continuation), ] Wrong continued indentation (remove 5 spaces).
else dv.DATAVIEW_CELL_INERT),
| ^
************* Module Beremiz_service
Beremiz_service.py:34: [W0611(unused-import), ] Unused import __builtin__

     1

#!/usr/bin/env python

     2

# -*- coding: utf-8 -*-

     3

     4

# This file is part of Beremiz runtime.

     5

#

     6

# Copyright (C) 2018: Edouard TISSERANT

     7

#

     8

# See COPYING.Runtime file for copyrights details.

     9

    10

from __future__ import absolute_import

    11

import sys

    12

from threading import Lock, Condition

    13

import six

    14

from six.moves import _thread

    15

    16

    17

class job(object):

    18

    """

    19

    job to be executed by a worker

    20

    """

    21

    def __init__(self, call, *args, **kwargs):

    22

        self.job = (call, args, kwargs)

    23

        self.result = None

    24

        self.success = False

    25

        self.exc_info = None

    26

    27

    def do(self):

    28

        """

    29

        do the job by executing the call, and deal with exceptions

    30

        """

    31

        try:

    32

            call, args, kwargs = self.job

    33

            self.result = call(*args, **kwargs)

    34

            self.success = True

    35

        except Exception:

    36

            self.success = False

    37

            self.exc_info = sys.exc_info()

    38

    39

    40

class worker(object):

    41

    """

    42

    serialize main thread load/unload of PLC shared objects

    43

    """

    44

    def __init__(self):

    45

        # Only one job at a time

    46

        self._finish = False

    47

        self._threadID = None

    48

        self.mutex = Lock()

    49

        self.todo = Condition(self.mutex)

    50

        self.done = Condition(self.mutex)

    51

        self.free = Condition(self.mutex)

    52

        self.job = None

    53

    54

    def reraise(self, job):

    55

        """

    56

        reraise exception happend in a job

    57

        @param job: job where original exception happend

    58

        """

    59

        exc_type = job.exc_info[0]

    60

        exc_value = job.exc_info[1]

    61

        exc_traceback = job.exc_info[2]

    62

        six.reraise(exc_type, exc_value, exc_traceback)

    63

    64

    def runloop(self, *args, **kwargs):

    65

        """

    66

        meant to be called by worker thread (blocking)

    67

        """

    68

        self._threadID = _thread.get_ident()

    69

        self.mutex.acquire()

    70

        if args or kwargs:

    71

            _job = job(*args, **kwargs)

    72

            _job.do()

    73

            if not _job.success:

    74

                self.reraise(_job)

    75

    76

        while not self._finish:

    77

            self.todo.wait()

    78

            if self.job is not None:

    79

                self.job.do()

    80

                self.done.notify()

    81

            else:

    82

                break

    83

    84

        self.mutex.release()

    85

    86

    def call(self, *args, **kwargs):

    87

        """

    88

        creates a job, execute it in worker thread, and deliver result.

    89

        if job execution raise exception, re-raise same exception

    90

        meant to be called by non-worker threads, but this is accepted.

    91

        blocking until job done

    92

        """

    93

    94

        _job = job(*args, **kwargs)

    95

    96

        if self._threadID == _thread.get_ident():

    97

            # if caller is worker thread execute immediately

    98

            _job.do()

    99

        else:

   100

            # otherwise notify and wait for completion

   101

            self.mutex.acquire()

   102

   103

            while self.job is not None:

   104

                self.free.wait()

   105

   106

            self.job = _job

   107

            self.todo.notify()

   108

            self.done.wait()

   109

            self.job = None

   110

            self.free.notify()

   111

            self.mutex.release()

   112

   113

        if _job.success:

   114

            return _job.result

   115

        else:

   116

            self.reraise(_job)

   117

   118

    def quit(self):

   119

        """

   120

        unblocks main thread, and terminate execution of runloop()

   121

        """

   122

        # mark queue

   123

        self._finish = True

   124

        self.mutex.acquire()

   125

        self.job = None

   126

        self.todo.notify()

   127

        self.mutex.release()