fix pylint warning '(expression-not-assigned) Expression "X" is assigned to nothing'
authorAndrey Skvortsov <andrej.skvortzov@gmail.com>
Wed, 18 Oct 2017 12:23:19 +0300
changeset 1876 995df4804221
parent 1875 62aaabbf8812
child 1877 da5f1fa46f2b
fix pylint warning '(expression-not-assigned) Expression "X" is assigned to nothing'
docutil/docsvg.py
tests/tools/check_source.sh
--- a/docutil/docsvg.py	Tue Oct 17 11:29:20 2017 +0300
+++ b/docutil/docsvg.py	Wed Oct 18 12:23:19 2017 +0300
@@ -45,7 +45,7 @@
     popenargs = [svgexepath]
     if svgfile is not None:
         popenargs.append(svgfile)
-    subprocess.Popen(popenargs).pid
+    subprocess.Popen(popenargs)
 
 
 def open_lin_svg(svgexepath, svgfile):
--- a/tests/tools/check_source.sh	Tue Oct 17 11:29:20 2017 +0300
+++ b/tests/tools/check_source.sh	Wed Oct 18 12:23:19 2017 +0300
@@ -204,6 +204,7 @@
     disable=$disable,W0122        # (exec-used) Use of exec
     disable=$disable,W0123        # (eval-used) Use of eval
     disable=$disable,I0011        # (locally-disabled) Locally disabling ungrouped-imports (C0412)
+    disable=$disable,R0204        # (redefined-variable-type) Redefinition of current type from X to Y
 
     # It'd be nice to fix warnings below some day
     disable=$disable,C0111        # missing-docstring
@@ -222,6 +223,7 @@
     disable=$disable,R0915        # (too-many-statements) Too many statements (57/50)
     disable=$disable,R0916        # (too-many-boolean-expressions) Too many boolean expressions in if statement (6/5)
     disable=$disable,R0101        # (too-many-nested-blocks) Too many nested blocks (7/5)
+    disable=$disable,R0801        # (duplicate-code) Similar lines in N files
 
     enable=
     enable=$enable,E1601          # print statement used
@@ -263,6 +265,7 @@
     enable=$enable,W0233          # (non-parent-init-called) __init__ method from a non direct base class 'X' is called
     enable=$enable,W0601          # (global-variable-undefined) Global variable 'X' undefined at the module level
     enable=$enable,W0623          # (redefine-in-handler) Redefining name 'X' from outer scope (line Y) in exception handler
+    enable=$enable,W0106          # (expression-not-assigned)
     # enable=
 
     options=