andrey@new-nest [Fri, 06 May 2016 22:21:22 +0300] rev 1516
fix bug: Beremiz IDE hangs during launching Beremiz_service
this is regression introduced as side effect by d7f474d [fix issue
with sometimes wrong return code of ProcessLogger]
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Fri, 06 May 2016 19:14:10 +0300] rev 1515
automatically detect flags supported by matiec and find correct path
for matiec C library files
This makes possible to use an old matiec and the new one.
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Fri, 06 May 2016 18:04:40 +0300] rev 1514
fix bug that appears if datatype in the project tree is renamed to wrong name (keyword, existend type,...)
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/_core.py", line 16765, in <lambda>
lambda event: event.callable(*event.args, **event.kw) )
File "/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/lib/expando.py", line 126, in _adjustCtrl
numLines = self.GetNumberOfLines()
File "/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/_core.py", line 16710, in __getattr__
raise PyDeadObjectError(self.attrStr % self._name)
PyDeadObjectError: The C++ part of the TreeTextCtrl object has been deleted, attribute access no longer allowed.
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Fri, 06 May 2016 16:16:30 +0300] rev 1513
add distribution license notice to about dialog as GPL requires
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Fri, 06 May 2016 14:45:06 +0300] rev 1512
add GPLv2 license
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Fri, 06 May 2016 14:05:44 +0300] rev 1511
add copyright notices to python files where there were missing, that
is required by GPLv2
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Fri, 06 May 2016 10:35:46 +0300] rev 1510
fix issue that was impossible to remove local instance of functional
block if pou is written in ST or IL
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Thu, 28 Apr 2016 16:54:01 +0300] rev 1509
fix highlighting of multiline comments in ST and IL
close #2
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Thu, 28 Apr 2016 15:21:02 +0300] rev 1508
fix error if non-latin character was entered in initial value in
data type element
Traceback (most recent call last):
File "/home/beremiz/editors/DataTypeEditor.py", line 575, in OnStructureElementsGridCellChange
value = self.StructureElementsTable.GetValue(row, col)
File "/home/beremiz/editors/DataTypeEditor.py", line 80, in GetValue
return str(value)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)
Traceback (most recent call last):
File "/home/beremiz/editors/DataTypeEditor.py", line 80, in GetValue
return str(value)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)
Traceback (most recent call last):
File "/home/beremiz/editors/DataTypeEditor.py", line 80, in GetValue
return str(value)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)
Andrey Skvortsov <andrej.skvortzov@gmail.com> [Thu, 28 Apr 2016 13:05:57 +0300] rev 1507
fix issue with sometimes wrong return code of ProcessLogger
As a result of wrong return code Beremiz gives folowing traceback:
Traceback (most recent call last):
File "./Beremiz.py", line 850, in OnMenu
getattr(self.CTR, method)()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 925, in _Build
IECGenRes = self._Generate_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 568, in _Generate_SoftPLC
return self._Compile_ST_to_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 661, in _Compile_ST_to_SoftPLC
C_files.remove("POUS.c")
ValueError: list.remove(x): x not in list
The problem is that both threads (for reading stdout and stderr) call self.Proc.poll(),
that updates internal returncode field. This call is done without any locking and the first thread gets correct result,
but other gets 0 as retval. If 0 gets thread, that afterwards calls callback finish, then wrong return code is returned
to the parent. Now only the thread with a callback polls for the return code, other thread just checked local value.
Additionally function spin() waits now until all threads finish reading their pipes, so the results are always correct.