tests/wxGlade/HMIFrame@wxglade_hmi/pyfile.xml
author Andrey Skvortsov <andrej.skvortzov@gmail.com>
Thu, 28 Apr 2016 13:05:57 +0300
changeset 1507 d7f474d10210
parent 1462 9ee3a2dea7e8
permissions -rw-r--r--
fix issue with sometimes wrong return code of ProcessLogger


As a result of wrong return code Beremiz gives folowing traceback:
Traceback (most recent call last):
File "./Beremiz.py", line 850, in OnMenu
getattr(self.CTR, method)()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 925, in _Build
IECGenRes = self._Generate_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 568, in _Generate_SoftPLC
return self._Compile_ST_to_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 661, in _Compile_ST_to_SoftPLC
C_files.remove("POUS.c")
ValueError: list.remove(x): x not in list

The problem is that both threads (for reading stdout and stderr) call self.Proc.poll(),
that updates internal returncode field. This call is done without any locking and the first thread gets correct result,
but other gets 0 as retval. If 0 gets thread, that afterwards calls callback finish, then wrong return code is returned
to the parent. Now only the thread with a callback polls for the return code, other thread just checked local value.

Additionally function spin() waits now until all threads finish reading their pipes, so the results are always correct.
1462
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     1
<?xml version='1.0' encoding='utf-8'?>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     2
<PyFile xmlns:xhtml="http://www.w3.org/1999/xhtml" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     3
  <variables/>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     4
  <globals>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     5
    <xhtml:p><![CDATA[]]></xhtml:p>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     6
  </globals>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     7
  <init>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     8
    <xhtml:p><![CDATA[]]></xhtml:p>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
     9
  </init>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    10
  <cleanup>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    11
    <xhtml:p><![CDATA[]]></xhtml:p>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    12
  </cleanup>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    13
  <start>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    14
    <xhtml:p><![CDATA[]]></xhtml:p>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    15
  </start>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    16
  <stop>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    17
    <xhtml:p><![CDATA[]]></xhtml:p>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    18
  </stop>
9ee3a2dea7e8 Extended wxHMI test
Edouard Tisserant
parents:
diff changeset
    19
</PyFile>