tests/python/beremiz.xml
author |
Andrey Skvortsov <andrej.skvortzov@gmail.com> |
|
Thu, 28 Apr 2016 13:05:57 +0300 |
changeset 1507 |
d7f474d10210 |
parent 1401 |
611fded24ce4
|
child 2231 |
7d87a0f98345 |
permissions |
-rw-r--r-- |
fix issue with sometimes wrong return code of ProcessLogger
As a result of wrong return code Beremiz gives folowing traceback:
Traceback (most recent call last):
File "./Beremiz.py", line 850, in OnMenu
getattr(self.CTR, method)()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 925, in _Build
IECGenRes = self._Generate_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 568, in _Generate_SoftPLC
return self._Compile_ST_to_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 661, in _Compile_ST_to_SoftPLC
C_files.remove("POUS.c")
ValueError: list.remove(x): x not in list
The problem is that both threads (for reading stdout and stderr) call self.Proc.poll(),
that updates internal returncode field. This call is done without any locking and the first thread gets correct result,
but other gets 0 as retval. If 0 gets thread, that afterwards calls callback finish, then wrong return code is returned
to the parent. Now only the thread with a callback polls for the return code, other thread just checked local value.
Additionally function spin() waits now until all threads finish reading their pipes, so the results are always correct.
1401
611fded24ce4
Pair with matiec a51a3bb4d613. Re-enable resource add/remove, updated CFLAGS, disabled broken global FG test in tests/python
Edouard Tisserant
diff
changeset
|
1 |
<?xml version='1.0' encoding='utf-8'?>
|
859
dbf82971f09d
More pedagogical tests/python. Should be renamed python_ctypes_and_C_pragmas_in_ST or something
Edouard Tisserant
diff
changeset
|
2 |
<BeremizRoot URI_location="LOCAL://">
|
728
e0424e96e3fd
refactoring - library support is not anymore attached to configtree nodes, but handles by project controller
Edouard Tisserant
diff
changeset
|
3 |
<TargetType/>
|
e0424e96e3fd
refactoring - library support is not anymore attached to configtree nodes, but handles by project controller
Edouard Tisserant
diff
changeset
|
4 |
</BeremizRoot>
|