targets/Win32/__init__.py
author Andrey Skvortsov <andrej.skvortzov@gmail.com>
Thu, 28 Apr 2016 13:05:57 +0300
changeset 1507 d7f474d10210
parent 1279 0eb9f8af479f
child 1511 91538d0c242c
permissions -rwxr-xr-x
fix issue with sometimes wrong return code of ProcessLogger


As a result of wrong return code Beremiz gives folowing traceback:
Traceback (most recent call last):
File "./Beremiz.py", line 850, in OnMenu
getattr(self.CTR, method)()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 925, in _Build
IECGenRes = self._Generate_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 568, in _Generate_SoftPLC
return self._Compile_ST_to_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 661, in _Compile_ST_to_SoftPLC
C_files.remove("POUS.c")
ValueError: list.remove(x): x not in list

The problem is that both threads (for reading stdout and stderr) call self.Proc.poll(),
that updates internal returncode field. This call is done without any locking and the first thread gets correct result,
but other gets 0 as retval. If 0 gets thread, that afterwards calls callback finish, then wrong return code is returned
to the parent. Now only the thread with a callback polls for the return code, other thread just checked local value.

Additionally function spin() waits now until all threads finish reading their pipes, so the results are always correct.
642
cd7ccbbbf471 various cleanups in /targets
Edouard Tisserant
parents: 621
diff changeset
     1
from ..toolchain_gcc import toolchain_gcc
203
cb9901076a21 Added concepts :
etisserant
parents:
diff changeset
     2
cb9901076a21 Added concepts :
etisserant
parents:
diff changeset
     3
class Win32_target(toolchain_gcc):
1279
0eb9f8af479f Added 'dlopen_prefix' class attributes to targets, in order to handle dlopen of shared object passed to runtime as extra file, and then in PWD (was working with windows only)
Edouard Tisserant
parents: 685
diff changeset
     4
    dlopen_prefix = ""
203
cb9901076a21 Added concepts :
etisserant
parents:
diff changeset
     5
    extension = ".dll"
290
3bd617ae7a05 Local Runtime (LOCAL://) now launched "on demand"
etisserant
parents: 203
diff changeset
     6
    def getBuilderLDFLAGS(self):
685
2db8b87016a0 Fixed Win32 timer up to 1ms
Edouard Tisserant
parents: 642
diff changeset
     7
        return toolchain_gcc.getBuilderLDFLAGS(self) + ["-shared", "-lwinmm"]