features.py
author Andrey Skvortsov <andrej.skvortzov@gmail.com>
Thu, 28 Apr 2016 13:05:57 +0300
changeset 1507 d7f474d10210
parent 944 52a17be9c4d1
child 1511 91538d0c242c
child 1909 bb883e063175
permissions -rw-r--r--
fix issue with sometimes wrong return code of ProcessLogger


As a result of wrong return code Beremiz gives folowing traceback:
Traceback (most recent call last):
File "./Beremiz.py", line 850, in OnMenu
getattr(self.CTR, method)()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 925, in _Build
IECGenRes = self._Generate_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 568, in _Generate_SoftPLC
return self._Compile_ST_to_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 661, in _Compile_ST_to_SoftPLC
C_files.remove("POUS.c")
ValueError: list.remove(x): x not in list

The problem is that both threads (for reading stdout and stderr) call self.Proc.poll(),
that updates internal returncode field. This call is done without any locking and the first thread gets correct result,
but other gets 0 as retval. If 0 gets thread, that afterwards calls callback finish, then wrong return code is returned
to the parent. Now only the thread with a callback polls for the return code, other thread just checked local value.

Additionally function spin() waits now until all threads finish reading their pipes, so the results are always correct.
784
a1d970365e41 Adding support for beremiz extensions to define custom file editors for project files
laurent
parents: 734
diff changeset
     1
libraries = [
944
52a17be9c4d1 Introduce Beremiz Native POU library. Now LOGGER POU is part of Beremiz' native POU library
Edouard Tisserant
parents: 784
diff changeset
     2
    ('Native', 'NativeLib.NativeLibrary'),
784
a1d970365e41 Adding support for beremiz extensions to define custom file editors for project files
laurent
parents: 734
diff changeset
     3
    ('Python', 'py_ext.PythonLibrary'),
a1d970365e41 Adding support for beremiz extensions to define custom file editors for project files
laurent
parents: 734
diff changeset
     4
    ('SVGUI', 'svgui.SVGUILibrary')]
10
2aff8e8cd456 Plugin skeleton base - python package
etisserant
parents:
diff changeset
     5
720
6be032177e2a refactoring
Edouard Tisserant
parents: 717
diff changeset
     6
catalog = [
721
ecf4d203c4d4 refactoring
Edouard Tisserant
parents: 720
diff changeset
     7
    ('canfestival', _('CANopen support'), _('Map located variables over CANopen'), 'canfestival.canfestival.RootClass'),
734
5c42cafaee15 Moved LPC sources to a separate project
Edouard Tisserant
parents: 731
diff changeset
     8
    ('c_ext', _('C extension'), _('Add C code accessing located variables synchronously'), 'c_ext.CFile'),
728
e0424e96e3fd refactoring - library support is not anymore attached to configtree nodes, but handles by project controller
Edouard Tisserant
parents: 721
diff changeset
     9
    ('py_ext', _('Python file'), _('Add Python code executed asynchronously'), 'py_ext.PythonFile'),
e0424e96e3fd refactoring - library support is not anymore attached to configtree nodes, but handles by project controller
Edouard Tisserant
parents: 721
diff changeset
    10
    ('wxglade_hmi', _('WxGlade GUI'), _('Add a simple WxGlade based GUI.'), 'wxglade_hmi.WxGladeHMI'),
e0424e96e3fd refactoring - library support is not anymore attached to configtree nodes, but handles by project controller
Edouard Tisserant
parents: 721
diff changeset
    11
    ('svgui', _('SVGUI'), _('Experimental web based HMI'), 'svgui.SVGUI')]
10
2aff8e8cd456 Plugin skeleton base - python package
etisserant
parents:
diff changeset
    12
784
a1d970365e41 Adding support for beremiz extensions to define custom file editors for project files
laurent
parents: 734
diff changeset
    13
file_editors = []