.hgignore
author Andrey Skvortsov <andrej.skvortzov@gmail.com>
Thu, 28 Apr 2016 13:05:57 +0300
changeset 1507 d7f474d10210
parent 955 7ef2f485c28f
child 1526 0fa5de94c131
child 1910 a375e31bf312
permissions -rw-r--r--
fix issue with sometimes wrong return code of ProcessLogger


As a result of wrong return code Beremiz gives folowing traceback:
Traceback (most recent call last):
File "./Beremiz.py", line 850, in OnMenu
getattr(self.CTR, method)()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 925, in _Build
IECGenRes = self._Generate_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 568, in _Generate_SoftPLC
return self._Compile_ST_to_SoftPLC()
File "/home/developer/WorkData/PLC/beremiz/beremiz/ProjectController.py", line 661, in _Compile_ST_to_SoftPLC
C_files.remove("POUS.c")
ValueError: list.remove(x): x not in list

The problem is that both threads (for reading stdout and stderr) call self.Proc.poll(),
that updates internal returncode field. This call is done without any locking and the first thread gets correct result,
but other gets 0 as retval. If 0 gets thread, that afterwards calls callback finish, then wrong return code is returned
to the parent. Now only the thread with a callback polls for the return code, other thread just checked local value.

Additionally function spin() waits now until all threads finish reading their pipes, so the results are always correct.
359
8049afde06ab prevent eclipse to push .project with .hgignore
'Gr?gory Tr?lat <gregory.trelat@lolitech.fr>'
parents:
diff changeset
     1
.project
441
379c66468cf6 added files to ignore in hgignore
Edouard TISSERANT <edouard.tisserant@gmail.com>
parents: 359
diff changeset
     2
379c66468cf6 added files to ignore in hgignore
Edouard TISSERANT <edouard.tisserant@gmail.com>
parents: 359
diff changeset
     3
syntax: regexp
944
52a17be9c4d1 Introduce Beremiz Native POU library. Now LOGGER POU is part of Beremiz' native POU library
Edouard Tisserant
parents: 734
diff changeset
     4
^tests/.*/build$
441
379c66468cf6 added files to ignore in hgignore
Edouard TISSERANT <edouard.tisserant@gmail.com>
parents: 359
diff changeset
     5
syntax: regexp
379c66468cf6 added files to ignore in hgignore
Edouard TISSERANT <edouard.tisserant@gmail.com>
parents: 359
diff changeset
     6
^.*\.pyc$
955
7ef2f485c28f More ignored files in .hgignore
Edouard Tisserant
parents: 944
diff changeset
     7
syntax: regexp
7ef2f485c28f More ignored files in .hgignore
Edouard Tisserant
parents: 944
diff changeset
     8
^.*~$
7ef2f485c28f More ignored files in .hgignore
Edouard Tisserant
parents: 944
diff changeset
     9
syntax: regexp
7ef2f485c28f More ignored files in .hgignore
Edouard Tisserant
parents: 944
diff changeset
    10
^.*\.swp$