dialogs/SFCStepNameDialog.py
changeset 714 131ea7f237b9
parent 446 0dd1a5f2a7a1
child 732 7991eb6bcb5a
--- a/dialogs/SFCStepNameDialog.py	Fri Jun 15 18:03:25 2012 +0200
+++ b/dialogs/SFCStepNameDialog.py	Mon Jun 25 20:03:53 2012 +0200
@@ -29,14 +29,6 @@
 
 class SFCStepNameDialog(wx.TextEntryDialog):
 
-    if wx.VERSION < (2, 6, 0):
-        def Bind(self, event, function, id = None):
-            if id is not None:
-                event(self, id, function)
-            else:
-                event(self, function)
-    
-
     def __init__(self, parent, message, caption = "Please enter text", defaultValue = "", 
                        style = wx.OK|wx.CANCEL|wx.CENTRE, pos = wx.DefaultPosition):
         wx.TextEntryDialog.__init__(self, parent, message, caption, defaultValue, style, pos)
@@ -44,39 +36,29 @@
         self.PouNames = []
         self.Variables = []
         self.StepNames = []
-        if wx.VERSION >= (2, 8, 0):
-            self.Bind(wx.EVT_BUTTON, self.OnOK, id=self.GetSizer().GetItem(2).GetSizer().GetItem(1).GetSizer().GetAffirmativeButton().GetId())
-        elif wx.VERSION >= (2, 6, 0):
-            self.Bind(wx.EVT_BUTTON, self.OnOK, id=self.GetSizer().GetItem(3).GetSizer().GetAffirmativeButton().GetId())
-        else:
-            self.Bind(wx.EVT_BUTTON, self.OnOK, id=self.GetSizer().GetItem(3).GetSizer().GetChildren()[0].GetSizer().GetChildren()[0].GetWindow().GetId())
-    
+        
+        self.Bind(wx.EVT_BUTTON, self.OnOK, 
+              self.GetSizer().GetItem(2).GetSizer().GetItem(1).GetSizer().GetAffirmativeButton())
+        
     def OnOK(self, event):
+        message = None
         step_name = self.GetSizer().GetItem(1).GetWindow().GetValue()
         if step_name == "":
-            message = wx.MessageDialog(self, _("You must type a name!"), _("Error"), wx.OK|wx.ICON_ERROR)
-            message.ShowModal()
-            message.Destroy()
+            message = _("You must type a name!")
         elif not TestIdentifier(step_name):
-            message = wx.MessageDialog(self, _("\"%s\" is not a valid identifier!")%step_name, _("Error"), wx.OK|wx.ICON_ERROR)
-            message.ShowModal()
-            message.Destroy()
+            message = _("\"%s\" is not a valid identifier!") % step_name
         elif step_name.upper() in IEC_KEYWORDS:
-            message = wx.MessageDialog(self, _("\"%s\" is a keyword. It can't be used!")%step_name, _("Error"), wx.OK|wx.ICON_ERROR)
-            message.ShowModal()
-            message.Destroy()
+            message = _("\"%s\" is a keyword. It can't be used!") % step_name
         elif step_name.upper() in self.PouNames:
-            message = wx.MessageDialog(self, _("A POU named \"%s\" already exists!")%step_name, _("Error"), wx.OK|wx.ICON_ERROR)
-            message.ShowModal()
-            message.Destroy()
+            message = _("A POU named \"%s\" already exists!") % step_name
         elif step_name.upper() in self.Variables:
-            message = wx.MessageDialog(self, _("A variable with \"%s\" as name already exists in this pou!")%step_name, _("Error"), wx.OK|wx.ICON_ERROR)
-            message.ShowModal()
-            message.Destroy()
+            message = _("A variable with \"%s\" as name already exists in this pou!") % step_name
         elif step_name.upper() in self.StepNames:
-            message = wx.MessageDialog(self, _("\"%s\" step already exists!")%step_name, _("Error"), wx.OK|wx.ICON_ERROR)
-            message.ShowModal()
-            message.Destroy()
+            message = _("\"%s\" step already exists!") % step_name
+        if message is not None:
+            dialog = wx.MessageDialog(self, message, _("Error"), wx.OK|wx.ICON_ERROR)
+            dialog.ShowModal()
+            dialog.Destroy()
         else:
             self.EndModal(wx.ID_OK)
 
@@ -88,6 +70,3 @@
 
     def SetStepNames(self, step_names):
         self.StepNames = [step_name.upper() for step_name in step_names]
-
-    def GetValue(self):
-        return self.GetSizer().GetItem(1).GetWindow().GetValue()