# HG changeset patch
# User Mario de Sousa <msousa@fe.up.pt>
# Date 1328266475 0
# Node ID f4a2d400ddbd02d91eba7f08740045f61e75a817
# Parent  c957f712ef4d0c1b591b08e4c4cad1cd925f3c3e
Adding support for semantic verification of FB calls in ST.

diff -r c957f712ef4d -r f4a2d400ddbd stage3/narrow_candidate_datatypes.cc
--- a/stage3/narrow_candidate_datatypes.cc	Thu Feb 02 16:50:12 2012 +0000
+++ b/stage3/narrow_candidate_datatypes.cc	Fri Feb 03 10:54:35 2012 +0000
@@ -84,12 +84,13 @@
 		do {
 			param_name = fp_iterator.next();
 			/* If there is no other parameter declared, then we are passing too many parameters... */
-			/* This error should have been caught in fill_candidate_datatypes_c */
-			if(param_name == NULL) ERROR;
+			/* This error should have been caught in fill_candidate_datatypes_c, but may occur here again when we handle FB invocations! */
+			if(param_name == NULL) return;
 		} while ((strcmp(param_name->value, "EN") == 0) || (strcmp(param_name->value, "ENO") == 0));
 
 		/* Set the desired datatype for this parameter, and call it recursively. */
 		call_param_value->datatype = base_type(fp_iterator.param_type());
+		if (NULL == call_param_value->datatype) ERROR;
 		call_param_value->accept(*this);
 
 		if (extensible_parameter_highest_index < fp_iterator.extensible_param_index())
@@ -134,8 +135,9 @@
 		param_name = fp_iterator.search(call_param_name);
 
 		/* Set the desired datatype for this parameter, and call it recursively. */
-		call_param_name->datatype = base_type(fp_iterator.param_type());
-		call_param_name->accept(*this);
+		call_param_value->datatype = base_type(fp_iterator.param_type());
+		if (NULL == call_param_value->datatype) ERROR;
+		call_param_value->accept(*this);
 
 		if (extensible_parameter_highest_index < fp_iterator.extensible_param_index())
 			extensible_parameter_highest_index = fp_iterator.extensible_param_index();
@@ -160,7 +162,8 @@
 	/* NOTE: symbol == NULL is valid. It will occur when, for e.g., an undefined/undeclared symbolic_variable is used
 	 *       in the code.
 	 */
-	return NULL;
+	if (symbol == NULL) return NULL;
+	return (symbol_c *)symbol->accept(search_base_type);	
 }
 
 /*********************/
@@ -1035,6 +1038,16 @@
 /* B 3.2.2 Subprogram Control Statements */
 /*****************************************/
 
+void *narrow_candidate_datatypes_c::visit(fb_invocation_c *symbol) {
+	symbol_c *fb_decl = search_varfb_instance_type->get_basetype_decl(symbol->fb_name);
+	if (NULL == fb_decl) ERROR;
+	if (NULL != symbol->nonformal_param_list)  narrow_nonformal_call(symbol, fb_decl);
+	if (NULL != symbol->   formal_param_list)     narrow_formal_call(symbol, fb_decl);
+
+	return NULL;
+}
+
+
 /********************************/
 /* B 3.2.3 Selection Statements */
 /********************************/
diff -r c957f712ef4d -r f4a2d400ddbd stage3/narrow_candidate_datatypes.hh
--- a/stage3/narrow_candidate_datatypes.hh	Thu Feb 02 16:50:12 2012 +0000
+++ b/stage3/narrow_candidate_datatypes.hh	Fri Feb 03 10:54:35 2012 +0000
@@ -196,6 +196,11 @@
     /*********************************/
     void *visit(assignment_statement_c *symbol);
 
+    /*****************************************/
+    /* B 3.2.2 Subprogram Control Statements */
+    /*****************************************/
+    void *visit(fb_invocation_c *symbol);
+    
     /********************************/
     /* B 3.2.3 Selection Statements */
     /********************************/