# HG changeset patch # User Mario de Sousa # Date 1331378869 0 # Node ID 933d6c2046079d0f0c3d51ebacccc9cff66288d6 # Parent d26759a2274a22840e1b61ace798f23e59faac40 Add a TODO comment. diff -r d26759a2274a -r 933d6c204607 stage3/fill_candidate_datatypes.cc --- a/stage3/fill_candidate_datatypes.cc Sat Mar 10 11:21:41 2012 +0000 +++ b/stage3/fill_candidate_datatypes.cc Sat Mar 10 11:27:49 2012 +0000 @@ -1089,6 +1089,10 @@ for(unsigned int j = 0; j < il_operand->candidate_datatypes.size(); j++) { prev_instruction_type = prev_il_instruction->candidate_datatypes[i]; operand_type = il_operand->candidate_datatypes[j]; + /* TODO: I believe the following is wrong! The data types of prev_instruction_type and operand_type DO NOT have to be equal. + * the prev_instruction_type MUST be BOOL compatible. + * I am not too sure about operand_type, does it have to be BOOL compatible, or can it be ANY_BIT compatible? Must check! + */ if (is_type_equal(prev_instruction_type,operand_type) && is_ANY_BOOL_compatible(operand_type)) add_datatype_to_candidate_list(symbol, prev_instruction_type); } @@ -1107,6 +1111,10 @@ for(unsigned int j = 0; j < il_operand->candidate_datatypes.size(); j++) { prev_instruction_type = prev_il_instruction->candidate_datatypes[i]; operand_type = il_operand->candidate_datatypes[j]; + /* TODO: I believe the following is wrong! The data types of prev_instruction_type and operand_type DO NOT have to be equal. + * the prev_instruction_type MUST be BOOL compatible. + * I am not too sure about operand_type, does it have to be BOOL compatible, or can it be ANY_BIT compatible? Must check! + */ if (is_type_equal(prev_instruction_type,operand_type) && is_ANY_BOOL_compatible(operand_type)) add_datatype_to_candidate_list(symbol, prev_instruction_type); }