diff -r a174d61f2087 -r 8a58d7b8b26c stage3/narrow_candidate_datatypes.cc --- a/stage3/narrow_candidate_datatypes.cc Tue Mar 13 18:29:34 2012 +0000 +++ b/stage3/narrow_candidate_datatypes.cc Tue Mar 13 19:04:07 2012 +0000 @@ -95,12 +95,13 @@ -bool narrow_candidate_datatypes_c::is_widening_compatible(const struct widen_entry widen_table[], symbol_c *left_type, symbol_c *right_type, symbol_c *result_type, bool &deprecated_status) { +bool narrow_candidate_datatypes_c::is_widening_compatible(const struct widen_entry widen_table[], symbol_c *left_type, symbol_c *right_type, symbol_c *result_type, bool *deprecated_status) { for (int k = 0; NULL != widen_table[k].left; k++) { if ((typeid(*left_type) == typeid(*widen_table[k].left)) && (typeid(*right_type) == typeid(*widen_table[k].right)) && (typeid(*result_type) == typeid(*widen_table[k].result))) { - deprecated_status = (widen_table[k].status == widen_entry::deprecated); + if (NULL != deprecated_status) + *deprecated_status = (widen_table[k].status == widen_entry::deprecated); return true; } } @@ -750,15 +751,17 @@ /*******************/ /* B 2.2 Operators */ /*******************/ -void *narrow_candidate_datatypes_c::handle_il_instruction_widen(symbol_c *symbol, bool &deprecated_operation, const struct widen_entry widen_table[]) { +void *narrow_candidate_datatypes_c::narrow_binary_operator(const struct widen_entry widen_table[], symbol_c *symbol, bool *deprecated_operation) { symbol_c *prev_instruction_type, *operand_type; int count = 0; - bool deprecated_status; if (NULL == symbol->datatype) /* next IL instructions were unable to determine the datatype this instruction should produce */ return NULL; + if (NULL != deprecated_operation) + *deprecated_operation = false; + /* NOTE 1: the il_operand __may__ be pointing to a parenthesized list of IL instructions. * e.g. LD 33 * AND ( 45 @@ -774,7 +777,6 @@ * is pointing to will be later narrowed by the call from the for() loop of the instruction_list_c * (or simple_instr_list_c), which iterates backwards. */ - deprecated_operation = false; for(unsigned int i = 0; i < fake_prev_il_instruction->candidate_datatypes.size(); i++) { for(unsigned int j = 0; j < il_operand->candidate_datatypes.size(); j++) { prev_instruction_type = fake_prev_il_instruction->candidate_datatypes[i]; @@ -789,7 +791,6 @@ } } } - // if (count > 1) ERROR; /* Since we also support SAFE data types, this assertion is not necessarily always tru! */ if (is_type_valid(symbol->datatype) && (count <= 0)) ERROR; @@ -799,6 +800,8 @@ + + void *narrow_candidate_datatypes_c::handle_il_instruction(symbol_c *symbol) { if (NULL == symbol->datatype) /* next IL instructions were unable to determine the datatype this instruction should produce */ @@ -914,11 +917,11 @@ void *narrow_candidate_datatypes_c::visit(ANDN_operator_c *symbol) {return handle_il_instruction(symbol);} void *narrow_candidate_datatypes_c::visit( ORN_operator_c *symbol) {return handle_il_instruction(symbol);} void *narrow_candidate_datatypes_c::visit(XORN_operator_c *symbol) {return handle_il_instruction(symbol);} -void *narrow_candidate_datatypes_c::visit( ADD_operator_c *symbol) {return handle_il_instruction_widen(symbol, symbol->deprecated_operation, widen_ADD_table);} -void *narrow_candidate_datatypes_c::visit( SUB_operator_c *symbol) {return handle_il_instruction_widen(symbol, symbol->deprecated_operation, widen_SUB_table);} -void *narrow_candidate_datatypes_c::visit( MUL_operator_c *symbol) {return handle_il_instruction_widen(symbol, symbol->deprecated_operation, widen_MUL_table);} -void *narrow_candidate_datatypes_c::visit( DIV_operator_c *symbol) {return handle_il_instruction_widen(symbol, symbol->deprecated_operation, widen_DIV_table);} -void *narrow_candidate_datatypes_c::visit( MOD_operator_c *symbol) {return handle_il_instruction(symbol);} +void *narrow_candidate_datatypes_c::visit( ADD_operator_c *symbol) {return narrow_binary_operator(widen_ADD_table, symbol, &(symbol->deprecated_operation));} +void *narrow_candidate_datatypes_c::visit( SUB_operator_c *symbol) {return narrow_binary_operator(widen_SUB_table, symbol, &(symbol->deprecated_operation));} +void *narrow_candidate_datatypes_c::visit( MUL_operator_c *symbol) {return narrow_binary_operator(widen_MUL_table, symbol, &(symbol->deprecated_operation));} +void *narrow_candidate_datatypes_c::visit( DIV_operator_c *symbol) {return narrow_binary_operator(widen_DIV_table, symbol, &(symbol->deprecated_operation));} +void *narrow_candidate_datatypes_c::visit( MOD_operator_c *symbol) {return narrow_binary_operator(widen_MOD_table, symbol);} void *narrow_candidate_datatypes_c::visit( GT_operator_c *symbol) {return handle_il_instruction(symbol);} void *narrow_candidate_datatypes_c::visit( GE_operator_c *symbol) {return handle_il_instruction(symbol);} void *narrow_candidate_datatypes_c::visit( EQ_operator_c *symbol) {return handle_il_instruction(symbol);} @@ -1005,6 +1008,33 @@ /***********************/ /* B 3.1 - Expressions */ /***********************/ +void *narrow_candidate_datatypes_c::narrow_binary_expression(const struct widen_entry widen_table[], symbol_c *symbol, symbol_c *l_expr, symbol_c *r_expr, bool *deprecated_operation) { + symbol_c *l_type, *r_type; + int count = 0; + + if (NULL != deprecated_operation) + *deprecated_operation = false; + + for(unsigned int i = 0; i < l_expr->candidate_datatypes.size(); i++) { + for(unsigned int j = 0; j < r_expr->candidate_datatypes.size(); j++) { + /* test widening compatibility */ + l_type = l_expr->candidate_datatypes[i]; + r_type = r_expr->candidate_datatypes[j]; + if (is_widening_compatible(widen_table, l_type, r_type, symbol->datatype, deprecated_operation)) { + l_expr->datatype = l_type; + r_expr->datatype = r_type; + count ++; + } + } + } +// if (count > 1) ERROR; /* Since we also support SAFE data types, this assertion is not necessarily always tru! */ + if (is_type_valid(symbol->datatype) && (count <= 0)) ERROR; + + l_expr->accept(*this); + r_expr->accept(*this); + return NULL; +} + void *narrow_candidate_datatypes_c::visit(or_expression_c *symbol) { symbol_c * selected_type = NULL; @@ -1229,127 +1259,13 @@ return NULL; } -void *narrow_candidate_datatypes_c::visit(add_expression_c *symbol) { - symbol_c *left_type, *right_type; - int count = 0; - bool deprecated_status; - - for(unsigned int i = 0; i < symbol->l_exp->candidate_datatypes.size(); i++) { - for(unsigned int j = 0; j < symbol->r_exp->candidate_datatypes.size(); j++) { - /* test widening compatibility */ - left_type = symbol->l_exp->candidate_datatypes[i]; - right_type = symbol->r_exp->candidate_datatypes[j]; - if (is_widening_compatible(widen_ADD_table, left_type, right_type, symbol->datatype, deprecated_status)) { - symbol->l_exp->datatype = left_type; - symbol->r_exp->datatype = right_type; - symbol->deprecated_operation = deprecated_status; - count ++; - } - } - } -// if (count > 1) ERROR; /* Since we also support SAFE data types, this assertion is not necessarily always tru! */ - if (is_type_valid(symbol->datatype) && (count <= 0)) ERROR; - - symbol->l_exp->accept(*this); - symbol->r_exp->accept(*this); - return NULL; -} - - - -void *narrow_candidate_datatypes_c::visit(sub_expression_c *symbol) { - symbol_c *left_type, *right_type; - int count = 0; - bool deprecated_status; - - for(unsigned int i = 0; i < symbol->l_exp->candidate_datatypes.size(); i++) { - for(unsigned int j = 0; j < symbol->r_exp->candidate_datatypes.size(); j++) { - /* test widening compatibility */ - left_type = symbol->l_exp->candidate_datatypes[i]; - right_type = symbol->r_exp->candidate_datatypes[j]; - if (is_widening_compatible(widen_SUB_table, left_type, right_type, symbol->datatype, deprecated_status)) { - symbol->l_exp->datatype = left_type; - symbol->r_exp->datatype = right_type; - symbol->deprecated_operation = deprecated_status; - count ++; - } - } - } -// if (count > 1) ERROR; /* Since we also support SAFE data types, this assertion is not necessarily always tru! */ - if (is_type_valid(symbol->datatype) && (count <= 0)) ERROR; - - symbol->l_exp->accept(*this); - symbol->r_exp->accept(*this); - return NULL; -} - - - -void *narrow_candidate_datatypes_c::visit(mul_expression_c *symbol) { - symbol_c *left_type, *right_type; - int count = 0; - bool deprecated_status; - - for(unsigned int i = 0; i < symbol->l_exp->candidate_datatypes.size(); i++) { - for(unsigned int j = 0; j < symbol->r_exp->candidate_datatypes.size(); j++) { - /* test widening compatibility */ - left_type = symbol->l_exp->candidate_datatypes[i]; - right_type = symbol->r_exp->candidate_datatypes[j]; - if (is_widening_compatible(widen_MUL_table, left_type, right_type, symbol->datatype, deprecated_status)) { - symbol->l_exp->datatype = left_type; - symbol->r_exp->datatype = right_type; - symbol->deprecated_operation = deprecated_status; - count ++; - } - } - } -// if (count > 1) ERROR; /* Since we also support SAFE data types, this assertion is not necessarily always tru! */ - if (is_type_valid(symbol->datatype) && (count <= 0)) ERROR; - - symbol->l_exp->accept(*this); - symbol->r_exp->accept(*this); - return NULL; -} - - - - -void *narrow_candidate_datatypes_c::visit(div_expression_c *symbol) { - symbol_c *left_type, *right_type; - int count = 0; - bool deprecated_status; - - for(unsigned int i = 0; i < symbol->l_exp->candidate_datatypes.size(); i++) { - for(unsigned int j = 0; j < symbol->r_exp->candidate_datatypes.size(); j++) { - /* test widening compatibility */ - left_type = symbol->l_exp->candidate_datatypes[i]; - right_type = symbol->r_exp->candidate_datatypes[j]; - if (is_widening_compatible(widen_DIV_table, left_type, right_type, symbol->datatype, deprecated_status)) { - symbol->l_exp->datatype = left_type; - symbol->r_exp->datatype = right_type; - symbol->deprecated_operation = deprecated_status; - count ++; - } - } - } -// if (count > 1) ERROR; /* Since we also support SAFE data types, this assertion is not necessarily always tru! */ - if (is_type_valid(symbol->datatype) && (count <= 0)) ERROR; - - symbol->l_exp->accept(*this); - symbol->r_exp->accept(*this); - return NULL; -} - - - - -void *narrow_candidate_datatypes_c::visit(mod_expression_c *symbol) { - symbol->l_exp->datatype = symbol->datatype; - symbol->l_exp->accept(*this); - symbol->r_exp->datatype = symbol->datatype; - symbol->r_exp->accept(*this); - return NULL; -} +void *narrow_candidate_datatypes_c::visit(add_expression_c *symbol) {return narrow_binary_expression(widen_ADD_table, symbol, symbol->l_exp, symbol->r_exp, &symbol->deprecated_operation);} +void *narrow_candidate_datatypes_c::visit(sub_expression_c *symbol) {return narrow_binary_expression(widen_SUB_table, symbol, symbol->l_exp, symbol->r_exp, &symbol->deprecated_operation);} +void *narrow_candidate_datatypes_c::visit(mul_expression_c *symbol) {return narrow_binary_expression(widen_MUL_table, symbol, symbol->l_exp, symbol->r_exp, &symbol->deprecated_operation);} +void *narrow_candidate_datatypes_c::visit(div_expression_c *symbol) {return narrow_binary_expression(widen_DIV_table, symbol, symbol->l_exp, symbol->r_exp, &symbol->deprecated_operation);} +void *narrow_candidate_datatypes_c::visit(mod_expression_c *symbol) {return narrow_binary_expression(widen_MOD_table, symbol, symbol->l_exp, symbol->r_exp);} + + void *narrow_candidate_datatypes_c::visit(power_expression_c *symbol) {