matiec: comparison stage3/fill_candidate

equal deleted inserted replaced

-:099aa5d655de
+:933c0dccc82f
 			param_name = fp_iterator.next();
 			/* If there is no other parameter declared, then we are passing too many parameters... */
 			if(param_name == NULL) return false;
 		} while ((strcmp(param_name->value, "EN") == 0) || (strcmp(param_name->value, "ENO") == 0));
+		/* TODO: verify if it is lvalue when INOUT or OUTPUT parameters! */
 		/* Get the parameter type */
 		param_datatype = base_type(fp_iterator.param_type());
 		/* check whether one of the candidate_data_types of the value being passed is the same as the param_type */
 		if (search_in_candidate_datatype_list(param_datatype, call_param_value->candidate_datatypes) < 0)
 /* returns true if compatible function/FB invocation, otherwise returns false */
 /* Assumes that the candidate_datatype lists of all the parameters being passed haved already been filled in */
-bool fill_candidate_datatypes_c::match_formal_call(symbol_c *f_call, symbol_c *f_decl) {
+bool fill_candidate_datatypes_c::match_formal_call(symbol_c *f_call, symbol_c *f_decl, symbol_c **first_param_datatype) {
 	symbol_c *call_param_value, *call_param_name, *param_datatype;
 	symbol_c *verify_duplicate_param;
 	identifier_c *param_name;
 	function_param_iterator_c       fp_iterator(f_decl);
 	function_call_param_iterator_c fcp_iterator(f_call);
 	int extensible_parameter_highest_index = -1;
 	identifier_c *extensible_parameter_name;
 	unsigned int i;
+	bool is_first_param = true;
 	/* Iterating through the formal parameters of the function call */
 	while((call_param_name = fcp_iterator.next_f()) != NULL) {
 		/* Obtaining the value being passed in the function call */
 		call_param_value = fcp_iterator.get_current_value();
 		} else ERROR;
 		/* check whether one of the candidate_data_types of the value being passed is the same as the param_type */
 		if (search_in_candidate_datatype_list(param_datatype, call_param_types) < 0)
 			return false; /* return false if param_type not in the list! */
+		/* If this is the first parameter, then copy the datatype to *first_param_datatype */
+		if (is_first_param)
+			if (NULL != first_param_datatype)
+				*first_param_datatype = param_datatype;
+		is_first_param = false;
 	}
 	/* call is compatible! */
 	return true;
 }
 /* handle implicit FB call in IL.
 * e.g.  CLK ton_var
 *        CU counter_var
-*
-* The algorithm will be to build a fake il_fb_call_c equivalent to the implicit IL FB call, and let
-* the visit(il_fb_call_c *) method handle it!
 */
 void fill_candidate_datatypes_c::handle_implicit_il_fb_call(symbol_c *il_instruction, const char *param_name, symbol_c *&called_fb_declaration) {
-	if (NULL == il_operand)
-		/* No FB to call was specified. There is nothing we can do... */
-		return;
 	symbol_c *fb_type_id = search_varfb_instance_type->get_basetype_id(il_operand);
-	/* This is a call to a non-declared FB/Variable is a semantic error (which is currently caught by stage 2, so this should never occur)
+	/* Although a call to a non-declared FB is a semantic error, this is currently caught by stage 2! */
-	 * or no operand was given (il_operand == NULL). In this case, we just give up!
+	if (NULL == fb_type_id) ERROR;
-	 */
-	if (NULL == fb_type_id)
-		return;
 	function_block_declaration_c *fb_decl = function_block_type_symtable.find_value(fb_type_id);
 	if (function_block_type_symtable.end_value() == fb_decl)
 		/* The il_operand is not the name of a FB instance. Most probably it is the name of a variable of some other type.
-		 * this is a smeantic error, so there is no way we can evaluate the rest of the code. We simply give up, and leave
+		 * this is a semantic error.
-		 * the candidate_datatype_list empty, and the called_fb_declaration pointing to NULL
 		 */
-		return;
+		fb_decl = NULL;
-	if (NULL == prev_il_instruction) {
+	/* The narrow_candidate_datatypes_c does not rely on this called_fb_declaration pointer being == NULL to conclude that
-		/* This IL implicit FB call (e.g. CLK ton_var) is not preceded by another IL instruction
+	 * we have a datatype incompatibility error, so we set it to fb_decl to allow the print_datatype_error_c to print out
-		 * (or list of instructions) that will set the IL current/default value.
+	 * more informative error messages!
-		 * We cannot proceed verifying type compatibility of something that does not ecist.
-		 */
-		return;
-	}
-	/* The value being passed to the 'param_name' parameter is actually the prev_il_instruction.
-	 * However, we do not place that object directly in the fake il_param_list_c that we will be
-	 * creating, since the visit(il_fb_call_c *) method will recursively call every object in that list.
-	 * The il_prev_intruction object has already been visited. We DO NOT want to visit it again.
-	 * The easiest way to work around this is to simply use a new object, and copy the relevant details to that object!
 	 */
-	symbol_c param_value = *prev_il_instruction;
+	called_fb_declaration = fb_decl;
-	identifier_c variable_name(param_name);
+	/* This implicit FB call does not change the value stored in the current/default IL variable */
-	// SYM_REF1(il_assign_operator_c, variable_name)
+	if (NULL != prev_il_instruction)
-	il_assign_operator_c il_assign_operator(&variable_name);
+		copy_candidate_datatype_list(prev_il_instruction/*from*/, il_instruction/*to*/);
-	// SYM_REF3(il_param_assignment_c, il_assign_operator, il_operand, simple_instr_list)
-	il_param_assignment_c il_param_assignment(&il_assign_operator, &param_value/*il_operand*/, NULL);
+	if (debug) std::cout << "handle_implicit_il_fb_call() [" << prev_il_instruction->candidate_datatypes.size() << "] ==> " << il_instruction->candidate_datatypes.size() << " result.\n";
-	il_param_list_c il_param_list;
-	il_param_list.add_element(&il_param_assignment);
-	// SYM_REF4(il_fb_call_c, il_call_operator, fb_name, il_operand_list, il_param_list, symbol_c *called_fb_declaration)
-	il_fb_call_c il_fb_call(NULL, il_operand, NULL, &il_param_list);
-	il_fb_call.accept(*this);
-	copy_candidate_datatype_list(&il_fb_call/*from*/, il_instruction/*to*/);
-	called_fb_declaration = il_fb_call.called_fb_declaration;
 }
 /* a helper function... */
 symbol_c *fill_candidate_datatypes_c::base_type(symbol_c *symbol) {
 /* subscript_list ',' subscript */
 // SYM_LIST(subscript_list_c)
 /* NOTE: we inherit from iterator visitor, so we do not need to implement this method... */
-#if 0
+// void *fill_candidate_datatypes_c::visit(subscript_list_c *symbol)
-void *fill_candidate_datatypes_c::visit(subscript_list_c *symbol) {
-}
-#endif
 /*  record_variable '.' field_selector */
 /*  WARNING: input and/or output variables of function blocks
 *           may be accessed as fields of a structured variable!
 /********************************/
 /* B 1.7 Configuration elements */
 /********************************/
 void *fill_candidate_datatypes_c::visit(configuration_declaration_c *symbol) {
-#if 0
 	// TODO !!!
 	/* for the moment we must return NULL so semantic analysis of remaining code is not interrupted! */
-#endif
 	return NULL;
 }
 /****************************************/
 /* B.2 - Language IL (Instruction List) */
 * | il_call_operator prev_declared_fb_name '(' eol_list il_param_list ')'
 */
 /* NOTE: The parameter 'called_fb_declaration'is used to pass data between stage 3 and stage4 (although currently it is not used in stage 4 */
 // SYM_REF4(il_fb_call_c, il_call_operator, fb_name, il_operand_list, il_param_list, symbol_c *called_fb_declaration)
 void *fill_candidate_datatypes_c::visit(il_fb_call_c *symbol) {
-	bool compatible = false;
+	/* We do not call
-	symbol_c *fb_decl = search_varfb_instance_type->get_basetype_decl(symbol->fb_name);
+	 * fb_decl = search_varfb_instance_type->get_basetype_decl(symbol->fb_name);
+	 * because we want to make sure it is a FB instance, and not some other data type...
+	 */
+	symbol_c *fb_type_id = search_varfb_instance_type->get_basetype_id(symbol->fb_name);
+	/* Although a call to a non-declared FB is a semantic error, this is currently caught by stage 2! */
+	if (NULL == fb_type_id) ERROR;
+	function_block_declaration_c *fb_decl = function_block_type_symtable.find_value(fb_type_id);
+	if (function_block_type_symtable.end_value() == fb_decl)
+		/* The fb_name not the name of a FB instance. Most probably it is the name of a variable of some other type. */
+		fb_decl = NULL;
 	/* Although a call to a non-declared FB is a semantic error, this is currently caught by stage 2! */
 	if (NULL == fb_decl) ERROR;
-	if (symbol->  il_param_list != NULL) {
+	if (symbol->  il_param_list != NULL) symbol->il_param_list->accept(*this);
-		symbol->il_param_list->accept(*this);
+	if (symbol->il_operand_list != NULL) symbol->il_operand_list->accept(*this);
-		compatible = match_formal_call(symbol, fb_decl);
-	}
-	if (symbol->il_operand_list != NULL) {
-		symbol->il_operand_list->accept(*this);
-		compatible = match_nonformal_call(symbol, fb_decl);
-	}
 	/* The print_datatypes_error_c does not rely on this called_fb_declaration pointer being != NULL to conclude that
 	 * we have a datat type incompatibility error, so setting it to the correct fb_decl is actually safe,
 	 * as the compiler will never reach the compilation stage!
 	 */
 	symbol->called_fb_declaration = fb_decl;
-	/* This object has the same candidate datatypes as the prev_il_instruction, since it does not change the value stored in the current/default IL variable. */
+	/* Let the il_call_operator (CAL, CALC, or CALCN) determine the candidate datatypes of the il_fb_call_c... */
-	copy_candidate_datatype_list(prev_il_instruction/*from*/, symbol/*to*/);
+	/* NOTE: We ignore whether the call is 'compatible' or not when filling in the candidate datatypes list.
+	 *       Even if it is not compatible, we fill in the candidate datatypes list correctly so that the following
+	 *       IL instructions may be handled correctly and debuged.
+	 *       Doing this is actually safe, as the parameter_list will still contain errors that will be found by
+	 *       print_datatypes_error_c, so the code will never reach stage 4!
+	 */
+	symbol->il_call_operator->accept(*this);
+	copy_candidate_datatype_list(symbol->il_call_operator/*from*/, symbol/*to*/);
 	if (debug) std::cout << "FB [] ==> "  << symbol->candidate_datatypes.size() << " result.\n";
 	return NULL;
 }
 /*****************************************/
 /* B 3.2.2 Subprogram Control Statements */
 /*****************************************/
 void *fill_candidate_datatypes_c::visit(fb_invocation_c *symbol) {
-	bool compatible = false;
+	symbol_c *fb_type_id = search_varfb_instance_type->get_basetype_id(symbol->fb_name);
-	symbol_c *fb_decl = search_varfb_instance_type->get_basetype_decl(symbol->fb_name);
+	/* Although a call to a non-declared FB is a semantic error, this is currently caught by stage 2! */
+	if (NULL == fb_type_id) ERROR;
+	function_block_declaration_c *fb_decl = function_block_type_symtable.find_value(fb_type_id);
+	if (function_block_type_symtable.end_value() == fb_decl)
+		/* The fb_name not the name of a FB instance. Most probably it is the name of a variable of some other type. */
+		fb_decl = NULL;
 	/* Although a call to a non-declared FB is a semantic error, this is currently caught by stage 2! */
 	if (NULL == fb_decl) ERROR;
-	if (symbol->   formal_param_list != NULL) {
+	if (symbol->   formal_param_list != NULL) symbol->formal_param_list->accept(*this);
-		symbol->formal_param_list->accept(*this);
+	if (symbol->nonformal_param_list != NULL) symbol->nonformal_param_list->accept(*this);
-		compatible = match_formal_call(symbol, fb_decl);
-	}
-	if (symbol->nonformal_param_list != NULL) {
-		symbol->nonformal_param_list->accept(*this);
-		compatible = match_nonformal_call(symbol, fb_decl);
-	}
 	/* The print_datatypes_error_c does not rely on this called_fb_declaration pointer being != NULL to conclude that
 	 * we have a datat type incompatibility error, so setting it to the correct fb_decl is actually safe,
 	 * as the compiler will never reach the compilation stage!
 	 */

changeset 455	933c0dccc82f
parent 454	099aa5d655de
child 456	ca8d98289ff9