# HG changeset patch
# User Florian Pose <fp@igh-essen.com>
# Date 1354812863 -3600
# Node ID 1cf54e2452c48e4ae62f1129ab8e628d5b83f856
# Parent  ec53d873dc5e2b8f711af378e589aebbdee5a16d
Removed unnecessary semaphore uses for emergency requests.

diff -r ec53d873dc5e -r 1cf54e2452c4 master/ioctl.c
--- a/master/ioctl.c	Thu Dec 06 15:53:21 2012 +0100
+++ b/master/ioctl.c	Thu Dec 06 17:54:23 2012 +0100
@@ -1955,9 +1955,7 @@
     if (unlikely(!ctx->requested))
         return -EPERM;
 
-    down(&master->io_sem);
     time_diff = ecrt_master_sync_monitor_process(master);
-    up(&master->io_sem);
 
     if (copy_to_user((void __user *) arg, &time_diff, sizeof(time_diff)))
         return -EFAULT;
@@ -2397,25 +2395,22 @@
     u8 msg[EC_COE_EMERGENCY_MSG_SIZE];
     int ret;
 
-    if (unlikely(!ctx->requested))
-        return -EPERM;
-
-    if (copy_from_user(&io, (void __user *) arg, sizeof(io)))
-        return -EFAULT;
-
-    if (down_interruptible(&master->master_sem)) {
-        return -EINTR;
-    }
+    if (unlikely(!ctx->requested)) {
+        return -EPERM;
+    }
+
+    if (copy_from_user(&io, (void __user *) arg, sizeof(io))) {
+        return -EFAULT;
+    }
+
+    /* no locking of master_sem needed, because configuration will not be
+     * deleted in the meantime. */
 
     if (!(sc = ec_master_get_config(master, io.config_index))) {
-        up(&master->master_sem);
         return -ENOENT;
     }
 
     ret = ecrt_slave_config_emerg_pop(sc, msg);
-
-    up(&master->master_sem);
-
     if (ret < 0) {
         return ret;
     }
@@ -2441,26 +2436,22 @@
     ec_slave_config_t *sc;
     int ret;
 
-    if (unlikely(!ctx->requested))
-        return -EPERM;
-
-    if (copy_from_user(&io, (void __user *) arg, sizeof(io)))
-        return -EFAULT;
-
-    if (down_interruptible(&master->master_sem)) {
-        return -EINTR;
-    }
+    if (unlikely(!ctx->requested)) {
+        return -EPERM;
+    }
+
+    if (copy_from_user(&io, (void __user *) arg, sizeof(io))) {
+        return -EFAULT;
+    }
+
+    /* no locking of master_sem needed, because configuration will not be
+     * deleted in the meantime. */
 
     if (!(sc = ec_master_get_config(master, io.config_index))) {
-        up(&master->master_sem);
-        return -ENOENT;
-    }
-
-    ret = ecrt_slave_config_emerg_clear(sc);
-
-    up(&master->master_sem);
-
-    return ret;
+        return -ENOENT;
+    }
+
+    return ecrt_slave_config_emerg_clear(sc);
 }
 
 /*****************************************************************************/
@@ -2477,25 +2468,22 @@
     ec_slave_config_t *sc;
     int ret;
 
-    if (unlikely(!ctx->requested))
-        return -EPERM;
-
-    if (copy_from_user(&io, (void __user *) arg, sizeof(io)))
-        return -EFAULT;
-
-    if (down_interruptible(&master->master_sem)) {
-        return -EINTR;
-    }
+    if (unlikely(!ctx->requested)) {
+        return -EPERM;
+    }
+
+    if (copy_from_user(&io, (void __user *) arg, sizeof(io))) {
+        return -EFAULT;
+    }
+
+    /* no locking of master_sem needed, because configuration will not be
+     * deleted in the meantime. */
 
     if (!(sc = ec_master_get_config(master, io.config_index))) {
-        up(&master->master_sem);
         return -ENOENT;
     }
 
     ret = ecrt_slave_config_emerg_overruns(sc);
-
-    up(&master->master_sem);
-
     if (ret < 0) {
         return ret;
     }