ID: 3459307 - Async problem in drivers/win32/win32.c

Windows CAN DLL driver sanity check.

Multiple instances CAN wirtual network for PEAK and Windows.

There is no English word "transfert". Fix all the typos.

Applyed changes from discussion '[Canfestival-devel] some minor CanFestival build suggestions', https://sourceforge.net/mailarchive/message.php?msg_id=28397766

[ canfestival-Bugs-3458203 ] Objdictedit

[ canfestival-Patches-3481330 ] Useless structure SHORT_CAN
[ canfestival-Patches-3481339 ] Useless local variable res in CanFestival\drivers\win32.c

Merge further Ica changes

Win32 IXXAT driver:
CHANGED: - Removed deprecated call to VCI_GetBrdTypeByName().
- The board type given to VCI2_PrepareBoard() is now always 0, because this parameter is not used.
- Removed the board_name parameter from IXXAT::open(). The board that should be opened is identified by the parameter board_number.
The correct parameter board_number can be determined using XAT_EnumHwEntry() and XAT_GetConfig().
- Changed the constructor IXXAT::IXXAT(). board->busname now only contains the board_number, see XAT_EnumHwEntry() and XAT_GetConfig().

Win32 IXXAT::
CHANGED: - removed newline from log messages

pdo.c:
FIXED: - fixed two wrong MSG_ERR calls

Win32:
CHANGED: - Switch character encoding to unicode.
- Changed logging format strings from %s to %S.
FIXED: - second argument to swprintf() is now the size of the target buffer

Win32 IXXAT:
CHANGED: - Changed logging format strings from %s to %S.

Win32:
FIXED: - The argument of LoadCanDriver() is LPCTSTR, not const char*

Win32 IXXAT driver:
ADDED: - Two additional log messages added, when initialization of the driver fails.
CHANGED: - Instead of writing directly into OutputDebugString() messages are printed using the new macro MSG_ERR_DRV().

Win32 applconfig:
CHANGED: - The MSG()-Makros for Visual Studio both print now to OutputDebugString().
ADDED: - Makro CANFESTIVAL_DEBUG_DRV_MSG() and MSG_ERR_DRV() to print into MSG() from a can driver implementation.

Win32 IXXAT driver:
FIXED: - A return value of 0 from VCI_ResetCan() and VCI_StartCan() indicates an error, too.
CHANGED: - The return values of VCI_ResetCan() and VCI_StartCan() are logged in case of an error.

SDO transfer:
FIXED: - Wrong SDO line could get changed due to a wrong parameter to setSDOlineRestBytes().

Win32-Dll:
CHANGED: - export the function sendOnePDOevent from the windows dll.

Win32-Timer:
CHANGED: - Timer implementation for win32 from absolute time (_ftime) to GetTickCount().
This fixes the following bug: When the system time was changed, a heartbeat timeout occurred.
FIXED: - Timeout seems only work properly if EnterMutex() is called before call of GetTickCount() (Patch from Roland Marquis)

FIXED: - The AVR example now compiles in linux.
- adapted AVR code to current default branch.

FIXED: - adapted paths for current vscom driver
- removed chmod +x vs_can_api.dll;
- added option -o to unzip command to overwrite existing files

FIXED: - the macro SUB_PROG_CFLAGS was overwritten for 64bit machines using gcc. Because of this the xenomai compilation failed.

Merged some canfestival-3-ica Fixes.

FIXED: - The AVR example now compiles in linux.
- adapted AVR code to current default branch.

FIXED: - adapted paths for current vscom driver
- removed chmod +x vs_can_api.dll;
- added option -o to unzip command to overwrite existing files

FIXED: - the macro SUB_PROG_CFLAGS was overwritten for 64bit machines using gcc. Because of this the xenomai compilation failed.

bug correction in sdo.c, in writeNetworkDictCallBackAI a call to _writeNetworkDict had endianize forced to 1

bug correction in dcf.c, an entry of only one byte was not checked

New feature : event timers allowed for RxPDOs (subidx 5 in RxPDO com paramaters)

Configuration manager with DCF in object 0x1F22 rewritten almost from scratch.
1. The boot-up message from a device starts a verification of entries
2. If all entries matches the node is started
3. If an entry differs the whole dcf is written and a save is done
4. A reset is send to the node
5. If several boot-up are received at the same time they will be managed one
by one thus only one free sdo client is needed for the whole process.

Added some fixes from Jaroslav Fojtik submitted on sourceforge bug tracker:
3096348 Missing "break" in states.c/canDispatch()
3096359 Crash inside dcf.c/send_consise_dcf()
3101891 Potencial overflow inside getNodeState()

Added include stdlib.h for malloc functions in sdo.c

patch from Stefan Kratochwil <entwicklung@inovel.de> : canfestival-3-fm3_698.patch
Bug:
If an object dictionary entry was requested whose size exceeds
SDO_MAX_LENGTH_TRANSFERT, the memcpy() call at line 139 of objacces.c overwrites
the memory after *pDestData which causes stack corruption.
-> Bugfix:
The bug was corrected by size checking the requested data. An 'Out of
memory' error message will be generated if the requested data exceeds
SDO_MAX_LENGTH_TRANSFERT.

Additional changes:
Added dynamic buffer allocation for the SDO transfer. This feature can be used
if SDO_DYNAMIC_BUFFER_ALLOCATION is defined in config.h. The size of the
dynamically allocated buffer is controlled with
SDO_DYNAMIC_BUFFER_ALLOCATION_SIZE.
-> Note:
This change removes the detection of OD_LENGTH_DATA_INVALID errors!

patch from Christian Taedcke <hacking@taedcke.com> : fix-wrong-resetSDOline-for-sdo-timeout.patch
FIXED: - The sdo line must not be closed at the end of SDOTimeoutAlarm() if the same sdo line is closed and reopened for a new transfer inside the callback. (Patch from Jaroslav Fojtik)

CHANGE: SDO block mode added, without CRC support
WARNING : API change in client functions

timers_unix.c : remove sigint and sigterm catch
sdo : Allow multiple servers
The sdo transfer struct is not anymore referenced by server's node id but by
client or server number in the OD. Node id is not relevant in SDO transfert.

fixed bug with cross wmingw build

Removed unneccessary overhead introduced with the last fix.

Fixed incorrect struct access in sendPDO() and inserted a missing variable in sendOnePDOEvent(). These errors occured at compile-time when configuring the project with './configure --debug=PDO' or './configure --debug=WAR'.

Fix some side effects of EDS import, while editing afterward

FIXED: - changed make targets from "%o: %c" to "%.o: %.c" (Patch from irc <oleg_osov>)
find . -name 'Make*' | xargs perl -w -i.bak -p -e "s/\%o: \%c/%.o: %.c/g"

FIX: - if a sdo transfer timeout occurres, reset the sdo line even if the callback function does not.

FIXED: - Sdo lines with the internal state SDO_ABORTED_ITERNAL are now closed.

CHANGED: - canSend message parameter is now a const pointer
ADDED : - IXXAT specific can bus watchdog to restart the VCI2 driver if a bus off, data ovverrun or remote queue overrun is detected. The can adapter cannot recover on its own.
* * *
CHANGED: - IXXAT::m_watchdogTimerId from DWORD to UINT_PTR to fix compiler warning

FIXED: - compiler warning from printf format string

FIXED: - TimerInit() was missing

FIXED: - OK and NOT OK was wrong in canSend()

FIXED: - bug while normal sdo transfer initialization (setting the byte count)

FIXED: - Renamed macro for peak win32 driver, patch from mailinglist (post from Christian Boepple, 2010-09-08 14:38)

CHANGED: - function sendOnePDOevent (CO_Data* d, UNS32 pdoNum) into sendOnePDOevent (CO_Data* d, UNS8 pdoNum)
- added explicit casts to remove compiler warnings

CHANGED: - added explicit cast to remove compiler warning

CHANGED: - canReceive and canSend return now 1 on error and 0 on success

CHANGED: - added explicit cast to remove compiler warning

FIXED: - added CALLBACK to can callback function prototypes

FIXED: - added missing endif
* * *
FIXED: - moved #include <linux/delay.h> into the ifdef __KERNEL__ block

CHANGED: - async access queue has now blocking read

ADDED: - pause() for win32
* * *
CHANGED: - moved pause implementation to main.cpp
- default driver to ixxat, baudrate to 125K and slaveid to 0x40
* * *
FIXED: - append "K" to baudrate
- added TimerInit()

CHANGED: - moved wxwidget header
ADDED: - getopt include for win32
FIXED: - TimerInit must be done for win32, too
* * *
CHANGED: - getopt signature (temp change)
* * *
CHANGED: - moved getopt and windows include

ADDED: - LeaveMutex and EnterMutex to exported symbols

CHANGED: - if variable starts with a digit, add a "_" at the beginning
* * *
FIXED: - if callback array name starts with a digit, prepend "_"

CHANGED: - option to integrate a can driver statically (hack)
FIXED: - missing () in log message
* * *
CHANGED: - adapted UnLoadCanDriver() for the macro NOT_USE_DYNAMIC_LOADING

CHANGED: - enabled console debugging for Visual Studio 2003 and below (without __VA_ARGS__).

ADDED: - dynamic memory allocation for sdo transfer using malloc and free
CHANGED: - enabled lss, enabled dynamic buffer allocation and set max sim sdo transfers to 32

ADDED: - new callback post_SlaveStateChange so that a master can monitor the state of its slave nodes using a heartbeat.
* * *
CHANGED: - added missing export for _post_SlaveStateChange (for revision #679)

get always the latest version of VSCAN API

Fix mingw32 cross build for can_peak_win32 and can_tcp_win32 server.

Fixed execution right on configure script

Piotr Trojanek (ptroja) cleanup patche. Thanks.

Moced CosateQ's doc at the right place, and fix PDO INHIBIT bit check error again.

CosateQ contribution.

Added contributed 402 profile

Fixed SDO loop in some situations.

Wrong check on PDO inhibit bit fixed.

Fix non freed windows handle. (thx to jaroslav.fojtik)

Update french translations

Obsolete example fixed

Bug in Subindex grid right click with i18n fixed

fixed typo in makefile

fixed typo in makefile

Enhancements for 'None' target : produce pre-linked object, remove some windows CRLF problems, fixed pedantic compiler warnings

added 'none' taget for building standalone library

Backed out changeset 3a6b413acad9

added files to ignor in hgignore

Wiped out references to Lolitech

Replace \"lolitech\" contact by \"edouard\" contact

changes merged

Fix some bug in debian packages

Extended PDO API with SendOnePDOEvent

Merge with daa1e1c3fba43ee73a2e827961155b1372ca433e

Verify if nodeId is strictly lesser than subindex entries count at the beginning of send_consise_dcf_loop function

Removing superfluous event.Skip()

create specific timer thread for UCLIBC support (with CLOCK_PROCESS_CPUTIME_ID parameter)

changes merged

-add LeaveMutex to avoid canopenshell deadlock when call NodeInit
-Now call the first setalarm from StartTimerLoop instead of the Timerthreadloop (like linux)

Fixed casts subject to problems on some compilers.

Fixed typo in can_socket.c

Some more reasonable timeout while waiting timer thread end

Fixed bug in the AVR-CAN driver: the CAN interrupt changes the
selected message object, but does not revert it before exiting.

add timeout for waitreceivetaskend for the win32, fix GetLastError print

Added timeout for waiting timer thread end on windows.

removed ligcc.a dependency and fix problem with errno value

Fixed wrong cast in sdo.c and wrong message length in nodeguarding

Fiwed use of socketopt accross RT and non-RT implementation of SocketCan

Updated memento with new Francis' version

re-use macro for objaccess

add some symbols from libgcc.a into libcanfestival_win32.a to maintain compatibility between mingw and msvc compilers

fix warnings with msvc compiler

add extern C to maintain compatibility with C++
fix warnings with msvc compiler

update config.h for win32 (for user which not use configure script)

Update CanFestival-3.def for visual studio users :
- Add TimerInit and TimerCleanup functions
- Add emcy functions

Replace macro functions for setODentry and getODentry
(prevent compilation errors with visual studio c++ compiler)

fix warnings with msvc compiler

update visual studio files

Replacing wx.Choice controls by wx.ComboBox controls

Bug with in access value translation and modification on subindex 0 of PDOmapping entries fixed

Merged changes

Adding support for displaying 'unknown' while datatype is not supported by CanFestival

Adding support for octet string

Adding support for internationalization

Fixed : postrm bug when upgrade package
Fixed : generated list of present driver library on the system for beremiz

add install/uninstall rules in Makefile.in

add extern \"C\" to keep compatibilty with C++

fix error in timer.c

fix warning when compile

Add print_getenv function wich print extra init params

rewrite comments

remove sync period from OD

fix method to exit properly the Timer Loop
fix time unit

fix method to exit properly CanReceiveLoop

fix message dialog when objdictedit can't find the pdf reader

fix some minor bugs

update manual

fixed : unlock and terminate CanReceive loop thread when canclose is called.

fixed bug in timerscfg.h for win32

Add new function defines to compile peak driver on win32

update canReceive_driver to match with Peak new read function (event)

updated manual_en.pdf with CANOpenShell example

Add doxygen comments in headers file
modify Doxyfile

Add new example CANOpenShell in manual

Remove old entries in visual studio files
Fix some bugs in CANOpenShell

Add build command for master OD and slave OD

remove automatic loading of manual with xpdf

Rewrite win32 code (C only)

Add new example : CANOpen shell

prevent eclipse to push .project with .hgignore

removed dead hidden files

remove autotools-dev dependency

update tags

fixed : deprecation warning with the module "sets" when using python 2.6

Adding support for loading any eds file (subindex 0 not corresponding to subindex number)

change LoliTech phone number for bug report

Added size information in generated object dictionnary header files (Objdictgen/gen_cfile.py)

Bug avoided reset PDO mapping fixed

Remove deletion PDO when mapping undefined in export to EDS

Fixed bugs in SDO caused by UNS8->UNS32 size patch.

Bug with wxRadioButton on Windows fixed

fixed bug in eds_utils.py (forget to convert to upper case)

fixed bug (forget to convert value in upper case)

Removed some warnings.

Changed OD size from UNS8 to UNS32, and repercuted change to PDO and SDO. Thanks to Jari Kuusisto for patch.

Fixed size checking in getReadResultNetworkDict. Thanks Jari Kuusisto.

Bug in file fixed

Adding index in PDO mapping names for differenciate mapped variables when they have the same name

Adding entries for Program Control in DS302 profile

Bug on DS302 Profile Dialog fixed

updated : debian package scripts

remove debian patches

updated : debian package scripts

Third time, Re-write doxygen tags in headers files to generate User API documentation

Second time, Re-write doxygen tags in headers files to generate User API documentation

Re-write doxygen tags in headers files to generate User API documentation

- Fix bug with relative path when node opened from command line
- Warning dialog when domain mapped variables not initialized

Fix bug when generate od cfile with a table of visible_string

1.2

1.29 Datatypes for timers

Fixed bug in Node.py function IsStringType : add domain type

Fixed serious bug in setAlarm, causing wrong timer duration when setAlarm not called long after timeDispatch.

V0.8

V0.8

Fixed typo in getReadResultNetworkDict

Remover SillySlave from LSS build

FastScan review

*** empty log message ***

Some instance type test improved

fix bug in canclose for win32

Some instance type test improved
Bug with $NODEID not in uppercase fixed

Some instance type test improved

Bug with x86_64 and gcc without -fPIC cflags fixed

Adding support for multiple element in 1010 and 1011

Adding support for DOMAIN object type in EDS parsing
Other bugs fixed

Added more correct signal handling to unix timers.

Added more correct signal handling to unix timers.

Patch from Jari K. implementing automatic SDO clien allocation, and add a new interface for (read/write)networkdict.

Adding support for replace imported EDS in nodelist

Added removal of dynamically loaded CAN driver interface library in clean make target

Fixed (again) return of abortcode value in SDO's getReadResultNetworkDict

Added removal of dynamically loaded CAN driver interface library in clean make target

Fixed incomplete resetSDOline

Bug on Concise DCF edit dialog value generating fixed

getReadResultNetworkDict now returns abortcode. Now, abort message should be sent correctly from client.

Edward's patch fixing nmtSlave compilation with LSS enabled.

cosmetic changes to pdo.c

*** empty log message ***

Changed getReadResultNetworkDict behaviour about size. Do not copy more data than pointet by Size arg.

add anagate device support in CanFestival

Modified initial value of 1014h to 0x80 + nodeid when 1014 is not included explicitly in the OD.

Fixed automatic SDO server creation for slave
Automatic PDO creation for slave
Remove PDO from EDS when mapping not defined

Segmentation Fault on closing fixed

Adding support for modification in CanFestival eds_utils

Modification for generating eds file from a node instead of a manager

Fixed missing refresh of title bar on Save.

Automatic SDO server added when creating new slave node.

added optional cancel button in node creation dialog (Beremiz)

Added embedded mode in objdictedit, for integration in Beremiz.

Added pointer variable list in GenCfile.py, for use with Beremiz's generated code.

LSS patch from Edward. Now, SetNodeId is not called from nmtslave anymore in case of LSS.

LSS patch from Edward. Now, SetNodeId is not called from nmtslave anymore in case of LSS.

Fixed some comments in sdo.c

Added missing const for dll names strings

Defining quick_index structures and ObjdictSize as constants

Implemented retry on SDO timeout in dcf.c.

"change baudrate" implemented for lincan interface

serious typo in dcf.c

Added NMT reset callbacks, patch from Edward

Fixed alignments problems on some 32bit target such as ARM or Xscale.

Added --binutils configure parameter : "--binutils=path Override binutils path detection (as regards $CC content) "

Updated SVG drawing to reflect recent changes in API.

Applied James patch that fixes can_cn4linux.c file descriptor handling and make it compatible with can_serial_hub.

Applied Edwards timer.c optimization patch.

Applied edward's patch for OD acces macros (optimization) and boudaries check (safety).

Fixed minor typos in timers_rtai.c and timers_xeno.c

kerneltest updated for the new api

fix bug MasterMap1 callback

fix bug in exit function
(add test to check if it is a master)

update Doxyfile , manual.tex
add Msys/mingw target in vscom interface

add rt_task_join for receive task and timerloop task

add TimerInit, TimerCleanup and Exit functions

add -mno-cygwin when linking with the vscom api dll

clean Makefile.in

- remove mlockall in timerloop
- move rt_task_delete from timerloop to TimerCleanup

add Exit function to DS401SlaveGui, change StopTimerLoop's arg and add TimerCleanup function in timers_win32