# HG changeset patch
# User Edouard Tisserant
# Date 1593434284 -7200
# Node ID f71c22b2ca25ca9bfd2c6e4ff4872ee256c7b409
# Parent  da8de4ef04497247ab110eacead2e4a195a13db7
Modbus: fix strange side effect of re-use of condition variables or mutex with Xenomai : without bzero of the associated types, mutex keeps locked.

diff -r da8de4ef0449 -r f71c22b2ca25 modbus/mb_runtime.c
--- a/modbus/mb_runtime.c	Wed Jun 24 14:38:11 2020 +0200
+++ b/modbus/mb_runtime.c	Mon Jun 29 14:38:04 2020 +0200
@@ -483,7 +483,6 @@
     sigaddset(&set, SIGALRM);
 
 	int client_node_id = (char *)_index - (char *)NULL; // Use pointer arithmetic (more portable than cast)
-    printf("%%d\n", client_node_id);
     /* initialize the timer that will be used to periodically activate the client node */
     {
         // start off by reseting the flag that will be set whenever the timer expires
@@ -611,6 +610,7 @@
 		client_nodes[index].init_state = 1; // we have created the node 
 		
 		/* initialize the mutex variable that will be used by the thread handling the client node */
+        bzero(&(client_nodes[index].mutex), sizeof(pthread_mutex_t));
         if (pthread_mutex_init(&(client_nodes[index].mutex), NULL) < 0) {
 			fprintf(stderr, "Modbus plugin: Error creating mutex for modbus client node %%s\n", client_nodes[index].location);
 			goto error_exit;                
@@ -618,6 +618,7 @@
 		client_nodes[index].init_state = 2; // we have created the mutex
 		
 		/* initialize the condition variable that will be used by the thread handling the client node */
+        bzero(&(client_nodes[index].condv), sizeof(pthread_cond_t));
         if (pthread_cond_init(&(client_nodes[index].condv), NULL) < 0) {
 			fprintf(stderr, "Modbus plugin: Error creating condition variable for modbus client node %%s\n", client_nodes[index].location);
 			goto error_exit;