# HG changeset patch
# User laurent
# Date 1337718583 -7200
# Node ID 96dd6650854d5be5dcdbe0ccb79313a43e322ef9
# Parent  bdab45f96aa0f64d525c9493976f3555bbc45ebb
Fixing Xenomai runtime specific parts to remove segmentation fault when stopping PLC

diff -r bdab45f96aa0 -r 96dd6650854d targets/Xenomai/plc_Xenomai_main.c
--- a/targets/Xenomai/plc_Xenomai_main.c	Tue May 22 06:41:54 2012 +0200
+++ b/targets/Xenomai/plc_Xenomai_main.c	Tue May 22 22:29:43 2012 +0200
@@ -104,10 +104,10 @@
 
     if (PLC_state & PLC_STATE_WAITPYTHON_PIPE_CREATED) {
         rt_pipe_delete(&WaitPython_pipe);
-        PLC_state &= ~PLC_STATE_WAITDEBUG_PIPE_CREATED;
-    }
-
-    if (PLC_state & PLC_STATE_WAITPYTHON_PIPE_CREATED) {
+        PLC_state &= ~PLC_STATE_WAITPYTHON_PIPE_CREATED;
+    }
+
+    if (PLC_state & PLC_STATE_WAITPYTHON_FILE_OPENED) {
         close(WaitPython_pipe_fd);
         PLC_state &= ~PLC_STATE_WAITPYTHON_FILE_OPENED;
     }
@@ -124,10 +124,10 @@
 
     if (PLC_state & PLC_STATE_PYTHON_PIPE_CREATED) {
         rt_pipe_delete(&Python_pipe);
-        PLC_state &= ~PLC_STATE_DEBUG_PIPE_CREATED;
-    }
-
-    if (PLC_state & PLC_STATE_PYTHON_PIPE_CREATED) {
+        PLC_state &= ~PLC_STATE_PYTHON_PIPE_CREATED;
+    }
+
+    if (PLC_state & PLC_STATE_PYTHON_FILE_OPENED) {
         close(Python_pipe_fd);
         PLC_state &= ~PLC_STATE_PYTHON_FILE_OPENED;
     }
@@ -136,11 +136,14 @@
 
 int stopPLC()
 {
+    /* Stop the PLC */
     PLC_shutdown = 1;
-    /* Stop the PLC */
-    PLC_SetTimer(0, 0);
+
+    /* Wait until PLC task stops */
+    rt_task_join(&PLC_task);
+
+    PLC_cleanup_all();
     __cleanup();
-    PLC_cleanup_all();
     __debug_tick = -1;
     return 0;
 }
@@ -166,6 +169,8 @@
     /* Define Ttick to 1ms if common_ticktime not defined */
     Ttick = common_ticktime__?common_ticktime__:1000000;
 
+    PLC_shutdown = 0;
+
     /*** RT Pipes creation and opening ***/
     /* create Debug_pipe */
     if(rt_pipe_create(&Debug_pipe, "Debug_pipe", DEBUG_PIPE_MINOR, PIPE_SIZE)) 
@@ -204,7 +209,7 @@
     PLC_state |= PLC_STATE_WAITPYTHON_FILE_OPENED;
 
     /*** create PLC task ***/
-    if(rt_task_create(&PLC_task, "PLC_task", 0, 50, 0)) goto error;
+    if(rt_task_create(&PLC_task, "PLC_task", 0, 50, T_JOINABLE)) goto error;
     PLC_state |= PLC_STATE_TASK_CREATED;
 
     if(__init(argc,argv)) goto error;
@@ -256,6 +261,7 @@
 {
     char cmd;
     int res;
+    if (PLC_shutdown) return -1;
     /* Wait signal from PLC thread */
     res = read(WaitDebug_pipe_fd, &cmd, sizeof(cmd));
     if (res == sizeof(cmd) && cmd == DEBUG_PENDING_DATA){
@@ -279,6 +285,7 @@
 int suspendDebug(int disable)
 {
     char cmd = DEBUG_UNLOCK;
+    if (PLC_shutdown) return -1;
     while(AtomicCompareExchange(
             &debug_state,
             DEBUG_FREE,
@@ -308,6 +315,7 @@
 int WaitPythonCommands(void)
 { 
     char cmd;
+    if (PLC_shutdown) return -1;
     /* Wait signal from PLC thread */
     if(read(WaitPython_pipe_fd, &cmd, sizeof(cmd))==sizeof(cmd) && cmd==PYTHON_PENDING_COMMAND){
         return 0;
@@ -334,6 +342,7 @@
 void LockPython(void)
 {
     char cmd = UNLOCK_PYTHON;
+    if (PLC_shutdown) return;
     while(AtomicCompareExchange(
             &python_state,
             PYTHON_FREE,
@@ -376,4 +385,3 @@
 void Remind(unsigned int offset, unsigned int count, void *p)
 {
 }
-