# HG changeset patch
# User Edouard Tisserant
# Date 1583502183 -3600
# Node ID 84c16ece8e108a0a762909c7b1fb2e1d169bf738
# Parent  b7650c6abeda0c0f89c3a8e9bbd4d3ace8a8c576
SVGHMI: fixed repeated error when Input widget is missing 'value' element

diff -r b7650c6abeda -r 84c16ece8e10 svghmi/gen_index_xhtml.xslt
--- a/svghmi/gen_index_xhtml.xslt	Fri Mar 06 14:42:08 2020 +0100
+++ b/svghmi/gen_index_xhtml.xslt	Fri Mar 06 14:43:03 2020 +0100
@@ -625,6 +625,8 @@
 </xsl:text>
     <xsl:text>var updates = {};
 </xsl:text>
+    <xsl:text>var page_switch = null;
+</xsl:text>
     <xsl:text>
 </xsl:text>
     <xsl:text>function dispatch_value_to_widget(widget, index, value, oldval) {
@@ -753,9 +755,21 @@
 </xsl:text>
     <xsl:text>// Apply updates recieved through ws.onmessage to subscribed widgets
 </xsl:text>
-    <xsl:text>// Called on requestAnimationFram, modifies DOM
-</xsl:text>
-    <xsl:text>function apply_pending_updates() {
+    <xsl:text>// Do the page swith if any one pending
+</xsl:text>
+    <xsl:text>// Called on requestAnimationFrame, modifies DOM
+</xsl:text>
+    <xsl:text>function animate() {
+</xsl:text>
+    <xsl:text>    if(page_switch != null){
+</xsl:text>
+    <xsl:text>        do_switch_page(page_switch);
+</xsl:text>
+    <xsl:text>        page_switch=null;
+</xsl:text>
+    <xsl:text>    }
+</xsl:text>
+    <xsl:text>
 </xsl:text>
     <xsl:text>    for(let index in updates){
 </xsl:text>
@@ -773,6 +787,24 @@
 </xsl:text>
     <xsl:text>
 </xsl:text>
+    <xsl:text>var requestAnimationFrameID = null;
+</xsl:text>
+    <xsl:text>function requestHMIAnimation() {
+</xsl:text>
+    <xsl:text>    if(requestAnimationFrameID != null){
+</xsl:text>
+    <xsl:text>        window.cancelAnimationFrame(requestAnimationFrameID);
+</xsl:text>
+    <xsl:text>        requestAnimationFrameID = null;
+</xsl:text>
+    <xsl:text>    }
+</xsl:text>
+    <xsl:text>    requestAnimationFrameID = window.requestAnimationFrame(animate);
+</xsl:text>
+    <xsl:text>}
+</xsl:text>
+    <xsl:text>
+</xsl:text>
     <xsl:text>// Message reception handler
 </xsl:text>
     <xsl:text>// Hash is verified and HMI values updates resulting from binary parsing
@@ -833,7 +865,7 @@
 </xsl:text>
     <xsl:text>        // register for rendering on next frame, since there are updates
 </xsl:text>
-    <xsl:text>        window.requestAnimationFrame(apply_pending_updates);
+    <xsl:text>        window.requestAnimationFrame(animate);
 </xsl:text>
     <xsl:text>    } catch(err) {
 </xsl:text>
@@ -1103,6 +1135,16 @@
 </xsl:text>
     <xsl:text>function switch_page(page_name) {
 </xsl:text>
+    <xsl:text>    page_switch = page_name;
+</xsl:text>
+    <xsl:text>    window.requestAnimationFrame(animate);
+</xsl:text>
+    <xsl:text>}
+</xsl:text>
+    <xsl:text>
+</xsl:text>
+    <xsl:text>function do_switch_page(page_name) {
+</xsl:text>
     <xsl:text>    let old_desc = page_desc[current_page];
 </xsl:text>
     <xsl:text>    let new_desc = page_desc[page_name];
@@ -1195,11 +1237,13 @@
 </xsl:text>
     <xsl:text>    svg_root.setAttribute('viewBox',new_desc.bbox.join(" "));
 </xsl:text>
+    <xsl:text>    
+</xsl:text>
     <xsl:text>    current_page = page_name;
 </xsl:text>
     <xsl:text>
 </xsl:text>
-    <xsl:text>    update_subscriptions();
+    <xsl:text>    window.setTimeout(update_subscriptions,0);
 </xsl:text>
     <xsl:text>};
 </xsl:text>
@@ -1408,14 +1452,15 @@
         <xsl:with-param name="mandatory" select="'no'"/>
       </xsl:call-template>
     </xsl:variable>
+    <xsl:variable name="have_value" select="string-length($value_elt)&gt;0"/>
     <xsl:value-of select="$value_elt"/>
-    <xsl:if test="$value_elt">
+    <xsl:if test="$have_value">
       <xsl:text>    frequency: 5,
 </xsl:text>
     </xsl:if>
     <xsl:text>    dispatch: function(value) {
 </xsl:text>
-    <xsl:if test="$value_elt">
+    <xsl:if test="$have_value">
       <xsl:text>        this.value_elt.textContent = String(value);
 </xsl:text>
     </xsl:if>
@@ -1445,7 +1490,11 @@
       <xsl:value-of select="func:escape_quotes(@inkscape:label)"/>
       <xsl:text>");
 </xsl:text>
-      <xsl:text>                    this.value_elt.textContent = String(new_val);});
+      <xsl:if test="$have_value">
+        <xsl:text>                    this.value_elt.textContent = String(new_val);
+</xsl:text>
+      </xsl:if>
+      <xsl:text>                   });
 </xsl:text>
     </xsl:for-each>
     <xsl:text>    },
diff -r b7650c6abeda -r 84c16ece8e10 svghmi/gen_index_xhtml.ysl2
--- a/svghmi/gen_index_xhtml.ysl2	Fri Mar 06 14:42:08 2020 +0100
+++ b/svghmi/gen_index_xhtml.ysl2	Fri Mar 06 14:43:03 2020 +0100
@@ -755,13 +755,14 @@
         const "value_elt" {
             optional_labels("value");
         }
+        const "have_value","string-length($value_elt)>0";
         value "$value_elt";
-        if "$value_elt"
+        if "$have_value"
         |     frequency: 5,
 
         |     dispatch: function(value) {
 
-        if "$value_elt"
+        if "$have_value"
         |         this.value_elt.textContent = String(value);
 
         |     },
@@ -776,7 +777,10 @@
         |         id("«@id»").addEventListener(
         |             "click", 
         |             evt => {let new_val = change_hmi_value(this.indexes[0], "«func:escape_quotes(@inkscape:label)»");
-        |                     this.value_elt.textContent = String(new_val);});
+            if "$have_value"{
+        |                     this.value_elt.textContent = String(new_val);
+            }
+        |                    });
                               /* TODO gray out value until refreshed */
         }
         |     },