1

#!/bin/sh

     2

# -*- coding: utf-8 -*-

     3

     4

# This file is part of Beremiz, a Integrated Development Environment for

     5

# programming IEC 61131-3 automates supporting plcopen standard and CanFestival.

     6

#

     7

# Copyright (C) 2017: Andrey Skvortsov

     8

#

     9

# See COPYING file for copyrights details.

    10

#

    11

# This program is free software; you can redistribute it and/or

    12

# modify it under the terms of the GNU General Public License

    13

# as published by the Free Software Foundation; either version 2

    14

# of the License, or (at your option) any later version.

    15

#

    16

# This program is distributed in the hope that it will be useful,

    17

# but WITHOUT ANY WARRANTY; without even the implied warranty of

    18

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

    19

# GNU General Public License for more details.

    20

#

    21

# You should have received a copy of the GNU General Public License

    22

# along with this program; if not, write to the Free Software

    23

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

    24

    25

    26

exit_code=0

    27

set_exit_error()

    28

{

    29

    if [ $exit_code -eq 0 ]; then

    30

       exit_code=1

    31

    fi

    32

}

    33

    34

version_gt()

    35

{

    36

    test "$(printf '%s\n' "$@" | sort -V | head -n 1)" != "$1";

    37

}

    38

    39

    40

compile_checks()

    41

{

    42

    echo "Syntax checking using python ..."

    43

    python --version

    44

    45

    # remove compiled Python files

    46

    find . -name '*.pyc' -exec rm -f {} \;

    47

    48

    for i in $py_files; do

    49

        # echo $i

    50

        python -m py_compile $i

    51

        if [ $? -ne 0 ]; then

    52

            echo "Syntax error in $i"

    53

            set_exit_error

    54

        fi

    55

    done

    56

    echo "DONE"

    57

    echo ""

    58

}

    59

    60

    61

python3_compile_checks()

    62

{

    63

    echo "Syntax checking using python3 ..."

    64

    python3 --version

    65

    66

    # remove compiled Python files

    67

    find . -name '*.pyc' -exec rm -f {} \;

    68

    69

    for i in $py_files; do

    70

        # echo $i

    71

        python3 -m py_compile $i

    72

        if [ $? -ne 0 ]; then

    73

            echo "Syntax error in $i"

    74

            set_exit_error

    75

        fi

    76

    done

    77

    78

    # remove compiled Python files

    79

    find . -name '*.pyc' -exec rm -f {} \;

    80

    81

    echo "DONE"

    82

    echo ""

    83

}

    84

    85

localization_checks()

    86

{

    87

    echo "Check correct localization formats"

    88

    xgettext --version

    89

    90

    for i in $py_files; do

    91

        xgettext -s --language=Python --package-name Beremiz --output=/tmp/m.pot $i 2>&1 | grep 'warning'

    92

        if [ $? -eq 0 ]; then

    93

            echo "Syntax error in $i"

    94

            set_exit_error

    95

        fi

    96

    done

    97

    echo "DONE"

    98

    echo ""

    99

}

   100

   101

# pep8 was renamed to pycodestyle

   102

# detect existed version

   103

pep8_detect()

   104

{

   105

    test -n $pep8 && (which pep8 > /dev/null) && pep8="pep8"

   106

    test -n $pep8 && (which pycodestyle > /dev/null) && pep8="pycodestyle"

   107

    if [ -z $pep8 ]; then

   108

        echo "pep8/pycodestyle is not found"

   109

        set_exit_error

   110

    fi

   111

    echo -n "pep8 version: "

   112

    $pep8 --version

   113

}

   114

   115

pep8_checks_default()

   116

{

   117

    echo "Check basic code-style problems for PEP-8"

   118

   119

    test -n $pep8 && pep8_detect

   120

    test -z $pep8 && return

   121

   122

    user_ignore=

   123

    # user_ignore=$user_ignore,E265  # E265 block comment should start with '# '

   124

    user_ignore=$user_ignore,E501  # E501 line too long (80 > 79 characters)

   125

   126

    # ignored by default,

   127

    default_ignore=

   128

    default_ignore=$default_ignore,E121  # E121 continuation line under-indented for hanging indent

   129

    default_ignore=$default_ignore,E123  # E123 closing bracket does not match indentation of opening bracket’s line

   130

    default_ignore=$default_ignore,E126  # E126 continuation line over-indented for hanging indent

   131

    default_ignore=$default_ignore,E133  # E133 closing bracket is missing indentation

   132

    default_ignore=$default_ignore,E226  # E226 missing whitespace around arithmetic operator

   133

    default_ignore=$default_ignore,E241  # E241 multiple spaces after ':'

   134

    default_ignore=$default_ignore,E242  # E242 tab after ‘,’

   135

    default_ignore=$default_ignore,E704  # E704 multiple statements on one line (def)

   136

    default_ignore=$default_ignore,W503  # W503 line break occurred before a binary operator

   137

    ignore=$user_ignore,$default_ignore

   138

   139

    # $pep8 --ignore $ignore --exclude build ./

   140

    $pep8 --max-line-length 300 --exclude build $py_files

   141

    if [ $? -ne 0 ]; then

   142

        set_exit_error

   143

    fi

   144

   145

    echo "DONE"

   146

    echo ""

   147

}

   148

   149

   150

pep8_checks_selected()

   151

{

   152

    echo "Check basic code-style problems for PEP-8 (selective)"

   153

   154

    test -n $pep8 && pep8_detect

   155

    test -z $pep8 && return

   156

   157

    # select checks:

   158

    user_select=

   159

    user_select=$user_select,W291   # W291 trailing whitespace

   160

    user_select=$user_select,E401   # E401 multiple imports on one line

   161

    user_select=$user_select,E265   # E265 block comment should start with '# '

   162

    user_select=$user_select,E228   # E228 missing whitespace around modulo operator

   163

    user_select=$user_select,W293   # W293 blank line contains whitespace

   164

    user_select=$user_select,E302   # E302 expected 2 blank lines, found 1

   165

    user_select=$user_select,E301   # E301 expected 2 blank lines, found 1

   166

    user_select=$user_select,E261   # E261 at least two spaces before inline comment

   167

    user_select=$user_select,E271   # E271 multiple spaces after keyword

   168

    user_select=$user_select,E231   # E231 missing whitespace after ','

   169

    user_select=$user_select,E303   # E303 too many blank lines (2)

   170

    user_select=$user_select,E225   # E225 missing whitespace around operator

   171

    user_select=$user_select,E711   # E711 comparison to None should be 'if cond is not None:'

   172

    user_select=$user_select,E251   # E251 unexpected spaces around keyword / parameter equals

   173

    user_select=$user_select,E227   # E227 missing whitespace around bitwise or shift operator

   174

    user_select=$user_select,E202   # E202 whitespace before ')'

   175

    user_select=$user_select,E201   # E201 whitespace after '{'

   176

    user_select=$user_select,W391   # W391 blank line at end of file

   177

    user_select=$user_select,E305   # E305 expected 2 blank lines after class or function definition, found X

   178

    user_select=$user_select,E306   # E306 expected 1 blank line before a nested definition, found X

   179

    user_select=$user_select,E703   # E703 statement ends with a semicolon

   180

    user_select=$user_select,E701   # E701 multiple statements on one line (colon)

   181

    user_select=$user_select,E221   # E221 multiple spaces before operator

   182

    user_select=$user_select,E741   # E741 ambiguous variable name 'l'

   183

    user_select=$user_select,E111   # E111 indentation is not a multiple of four

   184

    user_select=$user_select,E222   # E222 multiple spaces after operator

   185

    user_select=$user_select,E712   # E712 comparison to True should be 'if cond is True:' or 'if cond:'

   186

    user_select=$user_select,E262   # E262 inline comment should start with '# '

   187

    user_select=$user_select,E203   # E203 whitespace before ','

   188

    user_select=$user_select,E731   # E731 do not assign a lambda expression, use a def

   189

    user_select=$user_select,W601   # W601 .has_key() is deprecated, use 'in'

   190

    user_select=$user_select,E502   # E502 the backslash is redundant between brackets

   191

    user_select=$user_select,W602   # W602 deprecated form of raising exception

   192

    user_select=$user_select,E129   # E129 visually indented line with same indent as next logical line

   193

    user_select=$user_select,E127   # E127 continuation line over-indented for visual indent

   194

    user_select=$user_select,E128   # E128 continuation line under-indented for visual indent

   195

    user_select=$user_select,E125   # E125 continuation line with same indent as next logical line

   196

    user_select=$user_select,E114   # E114 indentation is not a multiple of four (comment)

   197

    user_select=$user_select,E211   # E211 whitespace before '['

   198

    user_select=$user_select,W191   # W191 indentation contains tabs

   199

    user_select=$user_select,E101   # E101 indentation contains mixed spaces and tabs

   200

    user_select=$user_select,E124   # E124 closing bracket does not match visual indentation

   201

    user_select=$user_select,E272   # E272 multiple spaces before keyword

   202

    user_select=$user_select,E713   # E713 test for membership should be 'not in'

   203

    user_select=$user_select,E122   # E122 continuation line missing indentation or outdented

   204

    user_select=$user_select,E131   # E131 continuation line unaligned for hanging indent

   205

    user_select=$user_select,E721   # E721 do not compare types, use 'isinstance()'

   206

    user_select=$user_select,E115   # E115 expected an indented block (comment)

   207

    user_select=$user_select,E722   # E722 do not use bare except'

   208

    user_select=$user_select,E266   # E266 too many leading '#' for block comment

   209

    user_select=$user_select,E402   # E402 module level import not at top of file

   210

    user_select=$user_select,W503   # W503 line break before binary operator

   211

   212

    $pep8 --select $user_select --exclude=build $py_files

   213

    if [ $? -ne 0 ]; then

   214

        set_exit_error

   215

    fi

   216

   217

    echo "DONE"

   218

    echo ""

   219

}

   220

   221

flake8_checks()

   222

{

   223

    echo "Check for problems using flake8 ..."

   224

   225

    which flake8 > /dev/null

   226

    if [ $? -ne 0 ]; then

   227

        echo "flake8 is not found"

   228

        set_exit_error

   229

        return

   230

    fi

   231

   232

    echo -n "flake8 version: "

   233

    flake8 --version

   234

   235

    flake8 --max-line-length=300  --exclude=build --builtins="_" $py_files

   236

    if [ $? -ne 0 ]; then

   237

        set_exit_error

   238

    fi

   239

   240

    echo "DONE"

   241

    echo ""

   242

}

   243

   244

pylint_checks()

   245

   246

{

   247

    echo "Check for problems using pylint ..."

   248

   249

    which pylint > /dev/null

   250

    if [ $? -ne 0 ]; then

   251

        echo "pylint is not found"

   252

        set_exit_error

   253

        return

   254

    fi

   255

    pylint --version

   256

   257

    export PYTHONPATH="$PWD/../CanFestival-3/objdictgen":$PYTHONPATH

   258

   259

    disable=

   260

    # These warnings most likely will not be fixed

   261

   262

    disable=$disable,C0103        # invalid-name

   263

    disable=$disable,C0326        # bad whitespace

   264

    disable=$disable,W0110        # (deprecated-lambda) map/filter on lambda could be replaced by comprehension

   265

    disable=$disable,W1401        # (anomalous-backslash-in-string) Anomalous backslash in string: '\.'. String constant might be missing an r prefix.

   266

    disable=$disable,W0613        # (unused-argument) Unused argument 'X'

   267

    disable=$disable,W0622        # (redefined-builtin) Redefining built-in

   268

    disable=$disable,W0621        # (redefined-outer-name) Redefining name 'Y' from outer scope (line X)

   269

    disable=$disable,W0122        # (exec-used) Use of exec

   270

    disable=$disable,W0123        # (eval-used) Use of eval

   271

    disable=$disable,I0011        # (locally-disabled) Locally disabling ungrouped-imports (C0412)

   272

    disable=$disable,R0204        # (redefined-variable-type) Redefinition of current type from X to Y

   273

    disable=$disable,R0201        # (no-self-use) Method could be a function

   274

    disable=$disable,W0221        # (arguments-differ) Arguments number differs from overridden 'X' method

   275

    disable=$disable,C0201        # (consider-iterating-dictionary) Consider iterating the dictionary directly instead of calling .keys()

   276

    disable=$disable,W0201        # (attribute-defined-outside-init) Attribute 'X' defined outside __init__

   277

    disable=$disable,I1101        # (c-extension-no-member) Module 'lxml.etree' has not 'X' member,

   278

                                  # but source is unavailable. Consider adding this module to extension-pkg-whitelist

   279

                                  # if you want to perform analysis based on run-time introspection of living objects.

   280

   281

    # It'd be nice to fix warnings below some day

   282

    disable=$disable,C0111        # missing-docstring

   283

    disable=$disable,W0703        # broad-except

   284

    disable=$disable,C0301        # Line too long

   285

    disable=$disable,C0302        # Too many lines in module

   286

    disable=$disable,W0511        # fixme

   287

    disable=$disable,R0901        # (too-many-ancestors) Too many ancestors (9/7)

   288

    disable=$disable,R0902        # (too-many-instance-attributes) Too many instance attributes (10/7)

   289

    disable=$disable,R0903        # (too-few-public-methods) Too few public methods (0/2)

   290

    disable=$disable,R0904        # (too-many-public-methods) Too many public methods (41/20)

   291

    disable=$disable,R0911        # (too-many-return-statements) Too many return statements (7/6)

   292

    disable=$disable,R0912        # (too-many-branches) Too many branches (61/12)

   293

    disable=$disable,R0913        # (too-many-arguments) Too many arguments (6/5)

   294

    disable=$disable,R0914        # (too-many-locals) Too many local variables (18/15)

   295

    disable=$disable,R0915        # (too-many-statements) Too many statements (57/50)

   296

    disable=$disable,R0916        # (too-many-boolean-expressions) Too many boolean expressions in if statement (6/5)

   297

    disable=$disable,R0101        # (too-many-nested-blocks) Too many nested blocks (7/5)

   298

    disable=$disable,R0801        # (duplicate-code) Similar lines in N files

   299

    disable=$disable,W0401        # (wildcard-import) Wildcard import 

   300

    disable=$disable,W0614        # (unused-wildcard-import), ] Unused import X from wildcard import

   301

    disable=$disable,W0212        # (protected-access) Access to a protected member X of a Y class

   302

    disable=$disable,E1101        # (no-member) Instance of 'X' has no 'Y' member

   303

   304

    enable=

   305

    enable=$enable,E1601          # print statement used

   306

    enable=$enable,C0325          # (superfluous-parens) Unnecessary parens after keyword

   307

    enable=$enable,W0404          # reimported module

   308

    enable=$enable,C0411          # (wrong-import-order) standard import "import x" comes before "import y"

   309

    enable=$enable,W0108          # (unnecessary-lambda) Lambda may not be necessary

   310

    enable=$enable,C0412          # (ungrouped-imports) Imports from package X are not grouped

   311

    enable=$enable,C0321          # (multiple-statements) More than one statement on a single line

   312

    enable=$enable,W0231          # (super-init-not-called) __init__ method from base class is not called

   313

    enable=$enable,W0105          # (pointless-string-statement) String statement has no effect

   314

    enable=$enable,W0311          # (bad-indentation) Bad indentation. Found 16 spaces, expected 12

   315

    enable=$enable,W0101          # (unreachable) Unreachable code

   316

    enable=$enable,E0102          # (function-redefined) method already defined

   317

    enable=$enable,W0602          # (global-variable-not-assigned) Using global for 'X' but no assignment is done

   318

    enable=$enable,W0611          # (unused-import) Unused import X

   319

    enable=$enable,C1001          # (old-style-class) Old-style class defined. Problem with PyJS

   320

    enable=$enable,W0102          # (dangerous-default-value) Dangerous default value {} as argument

   321

    enable=$enable,C0112          # (empty-docstring)

   322

    enable=$enable,W0631          # (undefined-loop-variable) Using possibly undefined loop variable 'X'

   323

    enable=$enable,W0104          # (pointless-statement) Statement seems to have no effect

   324

    enable=$enable,W0107          # (unnecessary-pass) Unnecessary pass statement

   325

    enable=$enable,W0406          # (import-self) Module import itself

   326

    enable=$enable,C0413          # (wrong-import-position) Import "import X" should be placed at the top of the module

   327

    enable=$enable,E1305          # (too-many-format-args) Too many arguments for format string

   328

    enable=$enable,E0704          # (misplaced-bare-raise) The raise statement is not inside an except clause

   329

    enable=$enable,C0123          # (unidiomatic-typecheck) Using type() instead of isinstance() for a typecheck.

   330

    enable=$enable,E0601          # (used-before-assignment) Using variable 'X' before assignment

   331

    enable=$enable,E1120          # (no-value-for-parameter) No value for argument 'X' in function call

   332

    enable=$enable,E0701          # (bad-except-order) Bad except clauses order (X is an ancestor class of Y)

   333

    enable=$enable,E0611          # (no-name-in-module) No name 'X' in module 'Y'

   334

    enable=$enable,E0213          # (no-self-argument) Method should have "self" as first argument

   335

    enable=$enable,E0401          # (import-error) Unable to import 'X'

   336

    enable=$enable,E1121          # (too-many-function-args) Too many positional arguments for function call

   337

    enable=$enable,W0232          # (no-init) Class has no __init__ method

   338

    enable=$enable,W0233          # (non-parent-init-called) __init__ method from a non direct base class 'X' is called

   339

    enable=$enable,W0601          # (global-variable-undefined) Global variable 'X' undefined at the module level

   340

    enable=$enable,W0111          # (assign-to-new-keyword) Name async will become a keyword in Python 3.7

   341

    enable=$enable,W0623          # (redefine-in-handler) Redefining name 'X' from outer scope (line Y) in exception handler

   342

    enable=$enable,W0109          # (duplicate-key) Duplicate key 'X' in dictionary

   343

    enable=$enable,E1310          # (bad-str-strip-call) Suspicious argument in str.strip call

   344

    enable=$enable,E1300          # (bad-format-character) Unsupported format character '"' (0x22) at index 17

   345

    enable=$enable,E1304          # (missing-format-string-key) Missing key 'X_name' in format string dictionary

   346

    enable=$enable,R1701          # (consider-merging-isinstance) Consider merging these isinstance calls to isinstance(CTNLDFLAGS, (str, unicode))

   347

    enable=$enable,R1704          # (redefined-argument-from-local) Redefining argument with the local name 'Y'

   348

    enable=$enable,W0106          # (expression-not-assigned) Expression "X" is assigned to nothing

   349

    enable=$enable,E1136          # (unsubscriptable-object) Value 'X' is unsubscriptable

   350

    enable=$enable,E0602          # (undefined-variable) Undefined variable 'X'

   351

    enable=$enable,W1618          # (no-absolute-import) import missing `from __future__ import absolute_import`

   352

    enable=$enable,W0403          # (relative-import) Relative import 'Y', should be 'X.Y '

   353

    enable=$enable,W0612          # (unused-variable) Unused variable 'X'

   354

    enable=$enable,C0330          # (bad-continuation) Wrong hanging indentation before block

   355

    enable=$enable,R0123          # (literal-comparison) Comparison to literal

   356

   357

    # python3 compatibility checks

   358

    enable=$enable,W1648          # (bad-python3-import) Module moved in Python 3

   359

    enable=$enable,W1613          # (xrange-builtin) xrange built-in referenced

   361

    # enable=

   362

   363

    options=

   364

   365

    ver=$(pylint --version 2>&1 | grep pylint  | awk '{ print $2 }')

   366

    if version_gt $ver '1.6.8'; then

   367

	echo "Use multiple threads for pylint"

   368

	options="$options --jobs=0 "

   369

    fi

   370

    options="$options --rcfile=.pylint"

   371

    # options="$options --py3k"   # report errors for Python 3 porting

   372

   373

    if [ -n "$enable" ]; then

   374

        options="$options --disable=all"

   375

        options="$options --enable=$enable"

   376

    else

   377

        options="$options --disable=$disable"

   378

    fi

   379

    # echo $options

   380

   381

    echo $py_files | xargs pylint $options

   382

    if [ $? -ne 0 ]; then

   383

        set_exit_error

   384

    fi

   385

   386

    echo "DONE"

   387

    echo ""

   388

}

   389

   390

   391

get_files_to_check()

   392

{

   393

    py_files=$(find . -name '*.py' -not -path '*/build/*')

   394

    if [ -e .hg/skiphook ]; then

   395

	echo "Skipping checks in the hook ..."

   396

	exit 0

   397

    fi

   398

    if [ "$1" = "--only-changes" ]; then

   399

        if which hg > /dev/null; then

   400

            if [ ! -z "$HG_NODE" ]; then

   401

                hg_change="--change $HG_NODE"

   402

                msg="for commit $HG_NODE"

   403

            else

   404

                hg_change=""

   405

                msg="in local repository"

   406

            fi

   407

            echo "Only changes ${msg} will be checked"

   408

            echo ""

   409

            py_files=$(hg status -m -a -n -I '**.py' $hg_change)

   410

            if [ $? -ne 0 ]; then

   411

                exit 1;

   412

            fi

   413

       fi

   414

    fi

   415

    if [ "$1" = "--files-to-check" ]; then

   416

        list="$2"

   417

        if [ -z "$list" ]; then

   418

            echo "--files-to-check requires filename as argument"

   419

            print_help

   420

        fi

   421

        if [ -e "$list" ]; then

   422

            py_files=$(cat $2 | grep '\.py$')

   423

        fi

   424

    fi

   425

    if [ -z "$py_files" ]; then

   426

        echo "No files to check"

   427

        exit 0;

   428

    fi

   429

}

   430

   431

   432

print_help()

   433

{

   434

    echo "Usage: check_source.sh [--only-changes | --files-to-check <filename> ]"

   435

    echo ""

   436

    echo "By default without arguments script checks all python source files"

   437

    echo ""

   438

    echo "--only-changes"

   439

    echo "                only files with local changes are checked. "

   440

    echo "                If script is called from mercurial pretxncommit hook,"

   441

    echo "                then only commited files are checked"

   442

    echo ""

   443

    echo "--files-to-check <file.lst>"

   444

    echo "                script read list of files to check from file.lst"

   445

   446

    exit 1

   447

}

   448

   449

main()

   450

{

   451

    get_files_to_check $@

   452

    python3_compile_checks

   453

    compile_checks

   454

    localization_checks

   455

    pep8_checks_default

   456

    # pep8_checks_selected

   457

   458

    # flake8_checks

   459

    pylint_checks

   460

    exit $exit_code

   461

}

   462

   463

[ "$1" = "--help" -o "$1" = "-h" ] && print_help

   464

main $@